New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add jina ai cloud restructure jcloud and hub #5298
Conversation
hanxiao
commented
Oct 21, 2022
- add login
- put jcloud and hub under jina ai cloud
- rename jina hub to executor hub
Signed-off-by: Han Xiao <han.xiao@jina.ai>
Signed-off-by: Han Xiao <han.xiao@jina.ai>
Signed-off-by: Han Xiao <han.xiao@jina.ai>
Signed-off-by: Han Xiao <han.xiao@jina.ai>
Codecov Report
@@ Coverage Diff @@
## master #5298 +/- ##
==========================================
+ Coverage 79.20% 85.80% +6.60%
==========================================
Files 99 99
Lines 6544 6544
==========================================
+ Hits 5183 5615 +432
+ Misses 1361 929 -432
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes and questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, last time I did the review GitHub thought I was just commenting. I've requested some changes
📝 Docs are deployed on https://docs-jina-ai-cloud--jina-docs.netlify.app 🎉 |
1 similar comment
📝 Docs are deployed on https://docs-jina-ai-cloud--jina-docs.netlify.app 🎉 |
@hanxiao given the failing k8s test, should I still go ahead and merge? Don't see how that test could fail given that this is just docs, but I'd rather be safe than sorry. CCing @JoanFM @samsja @JohannesMessner for an answer |