Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add jina ai cloud restructure jcloud and hub #5298

Merged
merged 16 commits into from Oct 23, 2022
Merged

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Oct 21, 2022

  • add login
  • put jcloud and hub under jina ai cloud
  • rename jina hub to executor hub

Signed-off-by: Han Xiao <han.xiao@jina.ai>
Signed-off-by: Han Xiao <han.xiao@jina.ai>
Signed-off-by: Han Xiao <han.xiao@jina.ai>
@hanxiao hanxiao requested a review from alexcg1 October 21, 2022 15:06
@github-actions github-actions bot added size/M area/docs This issue/PR affects the docs labels Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #5298 (3794fb2) into master (8cedfd3) will increase coverage by 6.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5298      +/-   ##
==========================================
+ Coverage   79.20%   85.80%   +6.60%     
==========================================
  Files          99       99              
  Lines        6544     6544              
==========================================
+ Hits         5183     5615     +432     
+ Misses       1361      929     -432     
Flag Coverage Δ
jina 85.80% <ø> (+6.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/serve/instrumentation/_aio_server.py 77.14% <0.00%> (-11.43%) ⬇️
jina/orchestrate/deployments/config/k8s.py 100.00% <0.00%> (+0.61%) ⬆️
jina/clients/base/websocket.py 88.57% <0.00%> (+0.95%) ⬆️
jina/clients/base/grpc.py 87.14% <0.00%> (+1.42%) ⬆️
jina/clients/mixin.py 95.00% <0.00%> (+1.66%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 94.26% <0.00%> (+1.91%) ⬆️
...a/orchestrate/deployments/config/docker_compose.py 99.01% <0.00%> (+1.96%) ⬆️
jina/serve/runtimes/gateway/request_handling.py 96.73% <0.00%> (+2.17%) ⬆️
jina/serve/runtimes/asyncio.py 84.07% <0.00%> (+2.65%) ⬆️
jina/clients/base/http.py 94.59% <0.00%> (+2.70%) ⬆️
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@alexcg1 alexcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes and questions

docs/fundamentals/executor/hub/sandbox.md Outdated Show resolved Hide resolved
docs/get-started/what-is-jina.md Outdated Show resolved Hide resolved
docs/jina-ai-cloud/index.md Outdated Show resolved Hide resolved
docs/jina-ai-cloud/index.md Outdated Show resolved Hide resolved
docs/jina-ai-cloud/index.md Outdated Show resolved Hide resolved
docs/jina-ai-cloud/login.md Outdated Show resolved Hide resolved
docs/jina-ai-cloud/login.md Outdated Show resolved Hide resolved
docs/jina-ai-cloud/login.md Outdated Show resolved Hide resolved
docs/jina-ai-cloud/login.md Outdated Show resolved Hide resolved
docs/jina-ai-cloud/login.md Outdated Show resolved Hide resolved
Copy link
Member

@alexcg1 alexcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, last time I did the review GitHub thought I was just commenting. I've requested some changes

@alexcg1 alexcg1 self-requested a review October 23, 2022 09:42
@github-actions
Copy link

📝 Docs are deployed on https://docs-jina-ai-cloud--jina-docs.netlify.app 🎉

1 similar comment
@github-actions
Copy link

📝 Docs are deployed on https://docs-jina-ai-cloud--jina-docs.netlify.app 🎉

@alexcg1
Copy link
Member

alexcg1 commented Oct 23, 2022

@hanxiao given the failing k8s test, should I still go ahead and merge? Don't see how that test could fail given that this is just docs, but I'd rather be safe than sorry.

CCing @JoanFM @samsja @JohannesMessner for an answer

@hanxiao hanxiao merged commit 41ea53e into master Oct 23, 2022
@hanxiao hanxiao deleted the docs-jina-ai-cloud branch October 23, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants