fix: new timer should keep labels #5341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/XS
area/core
Codecov Report
@@ Coverage Diff @@
## master #5341 +/- ##
=======================================
Coverage 86.69% 86.69%
=======================================
Files 99 99
Lines 6470 6470
=======================================
Hits 5609 5609
Misses 861 861
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
girishc13
previously approved these changes
Nov 2, 2022
|
@Jackmin801 do we need to add some tests? |
Jackmin801
force-pushed
the
fix-otel-metric-timer-missing-label
branch
from
68bc21f
to
0e8f502
Compare
JoanFM
previously approved these changes
Nov 2, 2022
Jackmin801
force-pushed
the
fix-otel-metric-timer-missing-label
branch
from
0e8f502
to
ec601d7
Compare
girishc13
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
The current decorator behaviour for MetricsTimer does not correctly save the labels assigned to the histogram.
This PR fixes this.
An example of the problem is in the tests.
The previous implementation would fail on the line: