fix: unblock event loop to allow health service #5433
Conversation
github-actions
bot
added
size/M
area/cicd
Codecov Report
@@ Coverage Diff @@
## master #5433 +/- ##
=======================================
Coverage 87.26% 87.26%
=======================================
Files 99 99
Lines 6566 6566
=======================================
Hits 5730 5730
Misses 836 836
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
JoanFM
force-pushed
the
executor-thread
branch
from
a6639d5
to
8d430c6
Compare
JoanFM
changed the title
| @pytest.mark.parametrize( | ||
| 'docker_images', [['slow-process-executor', 'jinaai/jina']], indirect=True | ||
| ) | ||
| async def test_slow_executor_readiness_probe_works(docker_images, tmpdir, logger): |
There was a problem hiding this comment.
I don't understand this specific test
why don't we just send requests in a separate process, do port forwarding and execute a manual health check (WorkerRuntime.is_ready).
In another PR that adds liveness probe we can modify this test
There was a problem hiding this comment.
what u say is done in the test_runtimes. This test adds little value for now. It proves that really slow works. We can remove later, or it will be more important when livenessProbe is there.
Let's keep for now
Goals:
Runs the Executor methods in a protected thread so that it is async and unlocks the event lock so that health service checks can pass