All the needed changes from Kodi 17 to 18 #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://forum.kodi.tv/showthread.php?tid=298565&pid=2471752#pid2471752 Adds all the needed elements for intial game support
fixed navigation related to id number changes
IsEmpty will no longer work under 18 and had to be fixed everywhere.
Replaced number strings with functioning ones.
just the first 2 missing icons
|
VERY much appreciated man -- have been so busy lately I just haven't had the chance. I'll look over this all in the next week or two. Cheers! |
|
Sounds good. |
Added support to launch ExtendedInfo script from video info
Add button in VideoOSD.xml to activate osdcmssettings issue jingai#109
Add some support for the new EPG variables jingai#32 by moving the seek time to a variable https://forum.kodi.tv/showthread.php?tid=298565&pid=2683795#pid2683795
For update jingai#34 https://forum.kodi.tv/showthread.php?tid=298565&pid=2705599#pid2705599 The subtitle now will open the new subtitle settings menu, unless "OneButtonSubtitles" is enabled, if so then the button turns the subtitles off and on unless there are no available subtitles, if none are available then the settings are launched instead and the user can download them from in there.
I'm not sure how it got left out the last time.
Shrink line so that skin can load
fix missing font reference
…eleting them. per new feature in script.skinshortcuts https://github.com/BigNoid/script.skinshortcuts/blob/master/resources/docs/started/Management%20Dialog.md
as per https://forum.kodi.tv/showthread.php?tid=327035 Settings button will display settings if artwork.beef is already installed, will display install button if not installed and the repo that hosts it is.
Add fanart and thumbs to background of main menu when widget is selected. (per user suggestion)
Added the ability to sort the order in which widget main menu background is displayed. Fixed the widget label to work even if the widget's contents are not in the databade (list a folder list)
Made a few slight changes that didn't impact the normal fontset visually so that the larger fonts don't look that bad. It doesn't look great, but for people that have trouble seeing the screen this might be a good compromise between style and function..
Shouldn't be noticeable, mostly just to the boundaries at the ends of lines.
-Fixed the missing studio and codec icons in the music visualization screen. -Fixed missing cdart support for Kodi 18. -Added Clearlogos for music artists and a setting to turn it off and on. -Added a larger CD case,discart and codec info tiles when you turn off the clock under music visualization settings. (per user suggestion)
Added artwork beef to musicinfo
Added the ability to display all available artwork in the upper right image location. There was no way of seeing what artwork was there or mssing before, the upper right image will cycle through all standard art files now.
minimum gui update for 19
Fixed include to match the file so Linux works again
|
Remind me not to step away from this for 4 years ever again... |
|
Almost all of this looks perfect in testing so far. Again, I am really sorry it took this long. A few things stand out:
I can fix all of these things. Just letting you know what is holding it up. I really appreciate all of the extra effort you've made over the last few years to keep this alive. Without you, I likely wouldn't even consider getting back into this. Thanks! |
|
Have merged everything (finally). Thanks again @MacGyverr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the needed changes from Kodi 17 to 18, as well as some that must have been changed under 17 that were fully removed from Kodi 18.