Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve name detection #51

Closed
JoshuaTrevor opened this issue Oct 16, 2019 · 1 comment
Closed

Improve name detection #51

JoshuaTrevor opened this issue Oct 16, 2019 · 1 comment
Assignees
Labels

Comments

@JoshuaTrevor
Copy link
Collaborator

Name detection has two significant ways it can be improved

  • By accounting for punctuation in the name which should tell the program certain words don't belong. Eg. capital letters where there shouldn't be, unclosed brackets and misplaced full stops.

  • By checking if GNParser returns an "unparsed tail" string which contains words adjacent to the sp./gen./comb. Because these words can be assumed to be in the name, this error means that too many words are included in front of the name (so remove the front word and try again)
    Since GNParser is a webservice it is important to do these checks in rounds, instead of 1 by 1 as that would increase the latency immensely and may also cause gnparser to flag the ip of the program's machine as malicious.

@JoshuaTrevor JoshuaTrevor self-assigned this Oct 16, 2019
@JoshuaTrevor
Copy link
Collaborator Author

Both methods have been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant