Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows support #16

Merged
merged 3 commits into from
May 9, 2015
Merged

Add windows support #16

merged 3 commits into from
May 9, 2015

Conversation

owenthereal
Copy link
Owner

No description provided.

@owenthereal owenthereal mentioned this pull request May 8, 2015
@owenthereal
Copy link
Owner Author

@mattn Would the use of github.com/mattn/go-isatty & github.com/mattn/go-colorable make cross compile impossible? I'm planning to let Travis CI (Linux) to cross compile ccat and provide builds for all platforms. People seem to be struggling with compiling it from source, e.g., #1

@owenthereal
Copy link
Owner Author

The code is actually working on Windows! But looks like the color is different from *nix's. Any way to tweak github.com/mattn/go-colorable?

screen shot 2015-05-08 at 6 34 30 am

@phase
Copy link

phase commented May 8, 2015

@jingweno What shell are you using?

@owenthereal
Copy link
Owner Author

@phase The git shell which should be a powershell.

@mattn
Copy link
Contributor

mattn commented May 9, 2015

go-isatty, go-colorable both are multi-platform compatible.

@mattn
Copy link
Contributor

mattn commented May 9, 2015

The code is actually working on Windows! But looks like the color is different from *nix's. Any way to tweak

Because your background color is blue, and windows console can display only 8 x 2(light/dark) colors.

@owenthereal
Copy link
Owner Author

Alright, let's merge this 👍

owenthereal added a commit that referenced this pull request May 9, 2015
@owenthereal owenthereal merged commit 769d6a0 into master May 9, 2015
@owenthereal owenthereal deleted the mattn-colorable branch May 9, 2015 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants