Make WebSocketTransport#resend async to avoid feedback loop that happ…

…ens if messages are sent during disconnection.
owenthereal · Oct 18, 2010 · 63056df · 63056df
1 parent e8a82c6
commit 63056df
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/javascript/network/browser.js b/javascript/network/browser.js
@@ -46,9 +46,14 @@ Faye.WebSocketTransport = Faye.Class(Faye.Transport, {
     };
   },
 
+  // We must do this asynchronously otherwise the socket can get
+  // into a feedback loop if messages were sent during disconnection
   resend: function() {
-    var messages = Faye.map(this._messages, function(id, msg) { return msg });
-    this.request(messages);
+    var self = this;
+    setTimeout(function() {
+      var messages = Faye.map(self._messages, function(id, msg) { return msg });
+      self.request(messages);
+    }, 10);
   }
 });