Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 #215

Closed
luismartingil opened this issue Aug 23, 2021 · 20 comments
Closed

Release 1.2.0 #215

luismartingil opened this issue Aug 23, 2021 · 20 comments

Comments

@luismartingil
Copy link

@rmorozov

  • Latest Release 1.1.0 is dated Jan, 2020
  • Do you think we could make an official release for 1.2.0? We'll try that RC to make it to Conan Center too...

FYI @danielmartinezruiz @league55

@rmorozov
Copy link
Member

Hello, @luismartingil!

As I see you would like to have release to Conan to be able to use jinja2cpp with new deps?

Anything else we need to include into this release except closing current PR's and maybe one-two bugs?

@luismartingil
Copy link
Author

Hello @rmorozov - thanks for the quick response!

Our concerns would be:

  1. Adding this PR into the Release
  2. Making it available in Conan Center

Can we assist you anyhow?

@rmorozov
Copy link
Member

  1. Sure I've started CI as soon as it completes I'll merge it.

  2. I am not quite familiar with a process of publication to Conan center - and that's a place where a help could be beneficial

But let's move sequentially - release, then publication.

@rmorozov
Copy link
Member

It seems that fix of #213 is also good candidate for release

@luismartingil
Copy link
Author

@rmorozov I answered in issue 213 - I don't think Clang-12 is officially supported at this time...

@rmorozov
Copy link
Member

@luismartingil , something like that https://github.com/jinja2cpp/Jinja2Cpp/releases/tag/1.2.0-beta ?=)

@luismartingil
Copy link
Author

@rmorozov Do you want us to check the beta release prior to making it official?

@rmorozov
Copy link
Member

@luismartingil , if it is possible, it would be great=)
as you main customer for this release, it is quite convenient to have your feedback prior to publication to Conan?

@luismartingil
Copy link
Author

@luismartingil , if it is possible, it would be great=)
as you main customer for this release, it is quite convenient to have your feedback prior to publication to Conan?

Ok give us some time, thanks!

@luismartingil
Copy link
Author

@rmorozov We're currently looking at this (@league55 FYI)

@league55
Copy link
Contributor

Looks good to me. I wasn't able to test it within our product, but the build, unit tests, and release content look good to me.
So, no blockers for final release from our side @rmorozov

@luismartingil fyi.

@luismartingil
Copy link
Author

@rmorozov Good to go for us!

@luismartingil
Copy link
Author

@rmorozov You're working on the latest details before the release, right?

@rmorozov
Copy link
Member

rmorozov commented Sep 1, 2021

@luismartingil , I think this version could be promoted to release.

And now I am working on replacing value-ptr with polymorphic value - #219

It seems that value-ptr is broken at master branch.

@rmorozov
Copy link
Member

rmorozov commented Sep 1, 2021

@rmorozov
Copy link
Member

rmorozov commented Sep 1, 2021

I'll try to fire new release when I'll manage to overcome problems in #219 + maybe some fixes you find in 1.2.0/1.2.1.

@rmorozov
Copy link
Member

rmorozov commented Sep 1, 2021

@luismartingil , as far as I understand know we need to make a PR to Conan-center-index?

@luismartingil
Copy link
Author

@rmorozov Right - here - we'll add it there

@luismartingil
Copy link
Author

@rmorozov FYI here

@luismartingil
Copy link
Author

@rmorozov Available in Conan now... thanks! conan-io/conan-center-index#7147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants