Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten: keep references to the AST throughout #614

Merged
merged 14 commits into from
Mar 25, 2023

Conversation

CohenArthur
Copy link
Member

The Fir will now be able to access AST nodes even deep in the pipeline, and to do so cheaply by just accessing a reference.

In the immediate future, this is useful for typechecking constants and accessing builtin types.

  • fir: Remove Default bounds where possible
  • flatten: Keep AST information in FlattenData
  • flatten: Add new AstInfo enum
  • ast-sanitizer: Use new Flatten API
  • include_code: Use new Flatten API
  • interpreter: Use new Flatten API
  • error: Add new with_opt_loc function, depreciate it
  • flatten: Add note about symbols from Constants
  • name_resolve: Use new Flatten API
  • typecheck: Use new Flatten API
  • xparser: Add new ast!() macro
  • name_resolve: Use xparser::ast! macro
  • flatten: Fix AstInfo::symbol in some cases
  • rec_typecheck: Use new Flatten API

@CohenArthur CohenArthur added enhancement New feature or request typechecker Issue related to typechecking in jinko labels Mar 25, 2023
@CohenArthur CohenArthur merged commit a803fd1 into master Mar 25, 2023
@CohenArthur CohenArthur deleted the flatten-keep-ast-references branch March 25, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request typechecker Issue related to typechecking in jinko
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant