Skip to content
This repository has been archived by the owner on Feb 19, 2019. It is now read-only.

Swift 4 Support #40

Closed
wants to merge 4 commits into from
Closed

Swift 4 Support #40

wants to merge 4 commits into from

Conversation

vknabel
Copy link

@vknabel vknabel commented Oct 10, 2017

Thank you very much for your great project!
Currently SDE doesn't work for Swift 4 projects as stated in #38.

Some dependencies have released updates, which broke the current master branch. I bumped the vscode engine dependency to ^1.16.0 as it is required by the language client (see microsoft/vscode-languageserver-node#248).
As a bonus, the implicit typescript update allowed me to remove a fixme and use generics.

Swift 4 probably renamed Swift 3.1's modules property to targets, when running swift package describe --type json (credits to @ainopara). Now SDE will simply fallback to targets, temporarily eliminating the crash. In the long run, there should be a better error message (e.g. "Swift version not supported.").

After all I haven't tested a lot (e.g. regression errors at runtime through dependency upgrades), but the basic functionality is now restored for Swift 4 on Macs (I'm not sure about Linux support though).

For the ones of you, who trust me and really need Swift 4 support as soon as possible, I uploaded the current vscode extension. If you need help for installing it, here is the the official installation guide.
sde-2.0.20171010.vsix.zip

@dcartman
Copy link

Thanks! Have been waiting patiently for Swift 4.0 support, will test the patch and hopefully it will be merged into mainline soon.

@jinmingjian
Copy link
Owner

@vknabel thanks for PR...
@dcartman and thanks for your watching...

But, as you seen, this project stopped for a while... Do you have interest to fork a new project? I'am glad to pin your new fork at the top of this project.

@vknabel
Copy link
Author

vknabel commented Oct 15, 2017

@jinmingjian I respect your decision and have to thank you very much for this project. Yes I am interested in maintaining SDE, although it may take a while to fully understand linux support.

An open question: shall I publish further updates as a new vscode Extension?

@jinmingjian
Copy link
Owner

@vknabel yes, because one extension is usually published by the individual developer on behave of his own account.

@renanyoy
Copy link

for me this update works, but when I'm using autocomplete I got two '.'
ex: self..engine..createCommandPool()

@vknabel
Copy link
Author

vknabel commented Feb 27, 2018

@jinmingjian could you add a link to the fork? vknabel/vscode-swift-development-environment

@LinusU
Copy link

LinusU commented Mar 7, 2018

@jinmingjian Is there no way to transfer ownership of the extension inside of VisualStudio Code? So that us users can get upgraded automatically? I would really appreciate it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants