This repository has been archived by the owner on Feb 19, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you very much for your great project!
Currently SDE doesn't work for Swift 4 projects as stated in #38.
Some dependencies have released updates, which broke the current master branch. I bumped the vscode engine dependency to
^1.16.0
as it is required by the language client (see microsoft/vscode-languageserver-node#248).As a bonus, the implicit typescript update allowed me to remove a fixme and use generics.
Swift 4 probably renamed Swift 3.1's
modules
property totargets
, when runningswift package describe --type json
(credits to @ainopara). Now SDE will simply fallback totargets
, temporarily eliminating the crash. In the long run, there should be a better error message (e.g. "Swift version not supported.").After all I haven't tested a lot (e.g. regression errors at runtime through dependency upgrades), but the basic functionality is now restored for Swift 4 on Macs (I'm not sure about Linux support though).
For the ones of you, who trust me and really need Swift 4 support as soon as possible, I uploaded the current vscode extension. If you need help for installing it, here is the the official installation guide.
sde-2.0.20171010.vsix.zip