Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Private member option in last version #8

Closed
oansquer opened this issue Dec 14, 2020 · 7 comments
Closed

Private member option in last version #8

oansquer opened this issue Dec 14, 2020 · 7 comments
Labels
bug Something isn't working

Comments

@oansquer
Copy link

Hello,

I checked the new option:

image

I restarted Visual Studio 2019 but I have warnings on private members:

image

Is this a bug?

Thank you.

Olivier Ansquer

@jinyafeng
Copy link
Owner

jinyafeng commented Dec 15, 2020

I tested this in my Visual Studio 2017 Community/Professional and Visual Studio 2019 Community. All of them are worked.
image

Please let me know whether the issue will be also reproduced at private class/constructor/property/method

Also let me know what version of VS you used.

@oansquer
Copy link
Author

I have VS 2019 pro:

image

I reproduce the problem on a new project:

image

It is as if the option was not taken into account.

@jinyafeng
Copy link
Owner

Okay, I will download a VS 2019 pro to see what will happen.

@jinyafeng
Copy link
Owner

It will really not be worked in VS 2019 Pro. I will fix it.
If you think warning line is not good, please use DocumentationAssistantPublicMembersOnly temporarily.
Thanks a lot you can report the bug.

@jinyafeng jinyafeng added the bug Something isn't working label Dec 15, 2020
@eggroll-bot
Copy link

This also doesn't work in VS 2019 Community. It is still showing the warning for private members even when the option is enabled.

@jinyafeng
Copy link
Owner

I updated my VS 2019 Community from 16.5.4 to 16.8.3. It doesn't work also.
It does can work at VS 2019 Community 16.5.4. The issue seems to relate to Visual Studio 2019 itself.

@jinyafeng
Copy link
Owner

Remove the option function because it is not working. you can still use the DocumentationAssistantPublicMembersOnly extension. I have updated it to VS2022. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants