Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Rollback to v1.21.3 due to performance regression #421

Merged
merged 3 commits into from
Nov 12, 2023
Merged

[Go] Rollback to v1.21.3 due to performance regression #421

merged 3 commits into from
Nov 12, 2023

Conversation

jinyus
Copy link
Owner

@jinyus jinyus commented Nov 12, 2023

Go 1.21.3:

Benchmark 1: ./related                                                                                                                                                                                           
Processing time (w/o IO): 22.833045ms                                                                                                                                                                            
Processing time (w/o IO): 22.473442ms                                                                                                                                                                            
Processing time (w/o IO): 22.452342ms                                                                                                                                                                            
Processing time (w/o IO): 22.577343ms                                                                                                                                                                            
Processing time (w/o IO): 22.634343ms                                                                                                                                                                            
Processing time (w/o IO): 22.614244ms                                                                                                                                                                            
Processing time (w/o IO): 22.825245ms
Processing time (w/o IO): 22.640344ms
Processing time (w/o IO): 22.697244ms
Processing time (w/o IO): 22.899046ms
Processing time (w/o IO): 22.462443ms
Processing time (w/o IO): 22.592644ms
Processing time (w/o IO): 22.733845ms
  Time (mean ± σ):      63.2 ms ±   1.6 ms    [User: 56.5 ms, System: 16.8 ms]
  Range (min … max):    60.9 ms …  65.6 ms    10 runs

Go 1.21.4 (same when targeting 1.21.3):

Benchmark 1: ./related
Processing time (w/o IO): 29.104746ms
Processing time (w/o IO): 29.117346ms
Processing time (w/o IO): 29.539248ms
Processing time (w/o IO): 29.363347ms
Processing time (w/o IO): 29.156646ms
Processing time (w/o IO): 29.333447ms
Processing time (w/o IO): 29.334247ms
Processing time (w/o IO): 29.206746ms
Processing time (w/o IO): 29.265047ms
Processing time (w/o IO): 29.184447ms
Processing time (w/o IO): 29.618848ms
Processing time (w/o IO): 29.185146ms
Processing time (w/o IO): 29.208746ms
  Time (mean ± σ):      69.9 ms ±   1.3 ms    [User: 63.9 ms, System: 16.3 ms]
  Range (min … max):    68.0 ms …  72.1 ms    10 runs

@jinyus jinyus merged commit c974114 into main Nov 12, 2023
@jinyus jinyus deleted the go_v branch November 12, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant