perf: vite-node + HMR 적용 #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarf005
force-pushed
the
ts-rest-v2
branch
5 times, most recently
from
8c1f1d7
to
c44d06b
Compare
Closed
Closed
jimin52
approved these changes
Jul 31, 2023
| @@ -29,6 +29,7 @@ services: | |||
| container_name: backend | |||
| build: | |||
| context: . | |||
| entrypoint: ["./node_modules/.bin/vite-node", "src/server.ts"] | |||
There was a problem hiding this comment.
entrypoint 를 Dockerfile 이 아닌 docker-compose 파일에서 실행해야 하나요?
궁금해서 질문드립니다.
There was a problem hiding this comment.
도커파일에 ENTRYPOINT를 사용해도 문제는 없습니다.
Lines 18 to 24 in e9fac6d
다만 도커파일에서는 ENTRYPOINT의 값이 변할 때마다 마지막 단계 캐싱이 무효화되어 해당 단계를 다시 빌드해야 하는 문제가 있었습니다. 이를 해결하기 위해 포트나 환경 변수 파일처럼, 컴포즈 파일에서 엔트리포인트를 관리하도록 변경했습니다.
Comment on lines
+13
to
+16
| "start": "npx vite-node src/server.ts", | ||
| "build": "pnpm --filter='@jiphyeonjeon-42/contracts' build", | ||
| "dev": "nodemon --watch src --watch ../contracts/dist --exec ts-node src/server.ts", | ||
| "prod": "pnpm build && pnpm start", | ||
| "dev": "vite-node --watch src/server.ts", | ||
| "standalone": "npm run build && npm run start", |
There was a problem hiding this comment.
변경된 명령어에 대해 어딘가 설명을 남겨주시면 감사드리겠습니다.
주석이나 README 혹은 docs 면 좋을 것 같습니다.
nyj001012
pushed a commit
that referenced
this pull request
Jul 31, 2023
* build: vite 추가 * build: vite + esm 모듈로 전환 * build: nodemon, ts-node 제거 * fix: entities를 named export로 변경 * perf: hmr 적용 --------- Co-authored-by: nocontribute <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
2023-07-19.14-09-54.mp4
backend/코드 뿐만 아니라 모노레포의contracts/패키지가 수정되어도 적용되는 것을 볼 수 있습니다. (contracts/에서 pnpm dev로 먼저 패키지를 실시간으로 빌드하도록 해야 합니다)변경점
pnpm dev로 실행 가능합니다기타