Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tag oriented feeds #213 #226

Merged
merged 2 commits into from Aug 12, 2015
Merged

Add support for tag oriented feeds #213 #226

merged 2 commits into from Aug 12, 2015

Conversation

a-b-r-o-w-n
Copy link
Contributor

Resolves #213

@@ -17,5 +17,9 @@ def show

def feed
@posts = Monologue::Post.published.limit(25)
if params[:tags].present?
tags = Monologue::Tag.where(name: params[:tags].split(',')).pluck(:id)
@posts = @posts.joins(:taggings).where('monologue_taggings.tag_id in (?)', tags)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [86/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) when pulling 2d0273f on astephenb:213-tag-oriented-feeds into 0ef9ed3 on jipiboily:master.

@msevestre
Copy link
Collaborator

Hey @astephenb . Thanks for the work on that. That's awesome
I will look at that PR next week and get back to you.
Cheers

@msevestre
Copy link
Collaborator

looking at it now!

@msevestre msevestre merged commit 2d0273f into jipiboily:master Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag oriented feeds.
4 participants