Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix security issues, other minor changes #2

Merged
merged 2 commits into from Jun 22, 2017
Merged

fix security issues, other minor changes #2

merged 2 commits into from Jun 22, 2017

Conversation

gaieges
Copy link
Contributor

@gaieges gaieges commented Jun 22, 2017

Fixes #1 .. also pulls from openvpn repo which has the updates for big security issues here:

https://guidovranken.wordpress.com/2017/06/21/the-openvpn-post-audit-bug-bonanza/

Follows approach documented here:
https://community.openvpn.net/openvpn/wiki/OpenvpnSoftwareRepos

Updates ports to be more accurate based on what pritunl comes with out of the box now.

@gaieges
Copy link
Contributor Author

gaieges commented Jun 22, 2017

Hmm taking a closer glance at this .. i'm not sure your port 9700 in the config is respected, have you seen that spin up the pritunl server up on that port? I only see it on 80 and 443.

Don't merge this yet lets resolve that and readme changes first.

@gaieges
Copy link
Contributor Author

gaieges commented Jun 22, 2017

Yeah ok .. so the port value isn't respected in the /etc/pritunl.conf:

root@b02bc15025a8:/# cat /etc/pritunl.conf
    {
        "mongodb_uri": "mongodb://localhost:27017/pritunl",
        "server_key_path": "/var/lib/pritunl/pritunl.key",
        "log_path": "/var/log/pritunl.log",
        "static_cache": true,
        "server_cert_path": "/var/lib/pritunl/pritunl.crt",
        "temp_path": "/tmp/pritunl_%r",
        "bind_addr": "0.0.0.0",
        "debug": true,
        "www_path": "/usr/share/pritunl/www",
        "local_address_interface": "auto",
        "port": 9700
    }
root@b02bc15025a8:/# netstat -l
Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State
tcp        0      0 127.0.0.11:44566        *:*                     LISTEN
tcp        0      0 localhost:9756          *:*                     LISTEN
tcp        0      0 localhost:27017         *:*                     LISTEN
tcp6       0      0 [::]:80                 [::]:*                  LISTEN
tcp6       0      0 [::]:443                [::]:*                  LISTEN
udp        0      0 127.0.0.11:52245        *:*

My thought is to just do away with the port option and just use 80/443. Thoughts?

@jippi
Copy link
Owner

jippi commented Jun 22, 2017

I think it looks good! 9700 is just what old versions used :)

@jippi jippi merged commit 1f21425 into jippi:master Jun 22, 2017
@jippi
Copy link
Owner

jippi commented Jun 22, 2017

Thanks for the PR ! nice improvements and nice to know it's more secure now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants