encode/decode UTF-8 in POMs #44
Conversation
jip/util.py
Outdated
| @@ -71,6 +71,7 @@ def download_string(url): | |||
| import requests | |||
| try: | |||
| response = requests.get(url, headers={ 'User-Agent': JIP_USER_AGENT}) | |||
| response.encoding = 'utf-8' | |||
There was a problem hiding this comment.
This doesn't seem to be required. I don't think it makes any sense to modify the response that comes from the server.
There was a problem hiding this comment.
Yes, it's a dubious operation, but Maven repository gives UTF-8 encoded files without content encoding header, so the 'requests' incorrectly assigns the 'iso-8859-1' encoding.
There was a problem hiding this comment.
Ok. But it doesn't seem to matter what 'requests' assigns. I've tried the code without setting the encoding attribute and it works. I think it is just metadata about the response that you can query if you want. But it doesn't affect how the data is interpreted.
test/install_test.py
Outdated
| @@ -18,6 +18,11 @@ def testResolve(self): | |||
| artifacts = _resolve_artifacts([junit]) | |||
| self.assertEqual(len(artifacts), 1) | |||
|
|
|||
| def testResolve2(self): | |||
There was a problem hiding this comment.
Can you please give the test method a more meaningful name? Like testResolveArtifactWithUmlautsInPom or so?
test/install_test.py
Outdated
| @@ -18,6 +18,11 @@ def testResolve(self): | |||
| artifacts = _resolve_artifacts([junit]) | |||
| self.assertEqual(len(artifacts), 1) | |||
|
|
|||
| def testResolve2(self): | |||
| junit = Artifact('de.l3s.boilerpipe', 'boilerpipe', '1.1.0') | |||
There was a problem hiding this comment.
Please rename the variable junit
Issue #43
Works for me. Tests are passed.