Implementation of --json CLI option #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Generated JSON file contains array called "data"
* Array "data" contains objects. Each object in this
array represents one entry. This object contains
only header ATM.
* Generated JSON could look like this ATM:
{
"data":[
{
"header":{
"handle":0,
"type":222,
"length":14
}
},
{
"header":{
"handle":1,
"type":14,
"length":8
}
}
]
}
* Big commit with lot of changes caused by chanche of pr_attr(), because it has new argument json_object. This small change caused lot of many changes in the code. As a result lot of information is printed to output.
* Big commit with lot of changes * It is possible to output list of flags, header_and_data, strings, etc. * TODO: Code in dmioutput.c needs refactoring, because there is lot of duplicated code now.
* New CLI option --json cannot be used with some other CLI options, because it would not make sense * Updated man page according this change
jirihnidek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR with proper implementation of
--jsonCLI option providing machine readable output. Compilation ofdmidecoderequiresjson-clibrary. When--jsonCLI option is used, then the output is written tostdoutusing JSON format. This could be useful, when other application tries to parse output ofdmidecode. Parsing of output does not require some special tool likejc. The code was tested withvalgrindand there should not be any memory leaks.Other changes:
--jsonwith some other CLI options like--dump-bin--jsonis used. Only information about version of SMBIOS and version od dmidecode is added to the output.