-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to unmute the audio #22
Comments
So from what I know, this issue and #26 are actually much more complicated than they look. I checked #23 and while the button doesn't even seem to work for me (the Mute || Unmute text is broken, but checking devtools the muted flag also doesn't get changed), but even if it did work (I manually removed the |
@styxpilled I tried the mute/unmute in a web browser and it worked fine |
Because Chromium or whatever has the audio codecs. And VSCode does not have these codecs, as it clearly stated here. Just because something works in a web browser doesn't mean it will work in the VSC webview.
So like, host a web server? That will cost you a pretty penny. |
Yes currently looking into the issue with playback without audio. I don't feel like transcoding videos on an external server tbh so I think I will just remove the option to unmute and leave it as it was before? |
yes ig... tho we could probably find some free hosting for video with mp3 codec. |
I think that's beyond of the scope of this extension at this point. It would require figuring out legal issues with licensing as long as the videos are stored on my servers afaik. |
Here's a drop in replacement for you 鉂わ笍 https://www.youtube.com/watch?v=L3SMytHheZY |
@styxpilled just for the sake of discussion and sharing ideas.. For remote files/videos on "mainstream" platforms, i don't know, especially regarding licensing/copyright issues. |
@aetonsi I don't know why you couldn't legally download videos from, lets say, Youtube with youtube-dl and play them back. How is that different from watching them in your browser? It's just that the VSCode team can't include various audio codecs because of licensing issues, and so we can't easily play it back in the webview. |
There are a lot of legal problems, even more than technical ones.
AFAIK you can download and reuse freely only the CC-BY licensed videos. The rest is under the Standard YouTube License so it's subject to whatever is in that license:
I looked up all of this a few years ago, because i wanted to use YT videos in a website and app of mine.. it was pretty messy On the technical side, would it be that complicated to spawn a terminal child process and reproduce audio there? |
Am I deaf or is the video really muted? 馃拃
Plspls, add the option to listen to the amazing Subway Surfers tunes while coding 馃グ
The text was updated successfully, but these errors were encountered: