Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is the build failing a red herring? #3

Closed
iffy opened this issue Jan 27, 2020 · 3 comments
Closed

Is the build failing a red herring? #3

iffy opened this issue Jan 27, 2020 · 3 comments

Comments

@iffy
Copy link

iffy commented Jan 27, 2020

I found this in the marketplace, but immediately dismissed it because the build badge said failing, and I (incorrectly) assumed that it only worked on Linux. I made my own, but don't want to duplicate effort. Is the badge a lie?
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
📝 change badge name #3
3729496
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
🐛 disable macOS test #3
403cce2
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
Merge pull request #4 from jiro4989/hotfix/#3-badge
4215a42 
📝 change badge name #3
@jiro4989
Copy link
Owner

@iffy

I think that setup-nim-actions works on Linux or Windows, but not working on macOS.

GitHub Actions had failed to test on macOS.
This is a problem of choosenim, is not a problem of setup-nim-action.
dom96/choosenim#122

setup-nim-actions uses internally choosenim.
This problem will be solved when a problem of choosenim will be solved.

Thank you.

@iffy
Copy link
Author

iffy commented Jan 27, 2020

Hmm... mine works on macOS using choosenim: https://github.com/iffy/install-nim

jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
🐛 choosenim command #3
cb0a838
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
➕ update libraries #3
61ea391
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
🔧 add job to print version #3
2ae3392
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
🔧 remove disable macOS #3
1aa9c83
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
🐛 add CHOOSENIM_NO_ANALYTICS env #3
57e2f61
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
➕ update js #3
670d1ff
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
✅ change test case #3
3ea13b1
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
🔥 remove CHOOSENIM_NO_ANALYTICS env #3
4ee280f
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
Revert ":fire: remove CHOOSENIM_NO_ANALYTICS env #3"
cd67fc0 
This reverts commit 4ee280f.
jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
🔥 remove test version #3
b2504ef
@jiro4989
Copy link
Owner

Thank you.
A problem is here.
4ee280f#diff-49f374184f7542706ae947de9d44718eL58

The crash was solved when I set CHOOSENIM_NO_ANALYTICS.

jiro4989 added a commit that referenced this issue Jan 27, 2020
@jiro4989
📝 update version #3
4f114f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iffy @jiro4989