Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate which element in the collection failed validation. #5

Closed
wants to merge 1 commit into from
Closed

Conversation

lread
Copy link
Contributor

@lread lread commented May 16, 2014

I find it helpful to know which element in the collection failed validation. This change indicates the index of the offending element in the propertyPath.

For example, if item at index 4 failed validation, our propertyPath is now valueList[4] instead of the current valueList.

@jirutka
Copy link
Owner

jirutka commented May 16, 2014

This is very useful, thanks for great pull-request! 👍

I didn’t know that since 5.x it’s finally possible to specify index without need to add a property node. However, there’s a little problem that it’s not compatible with HV 4.3.1 (that’s why Travis failed). I have to think if it’s worth to make a similar workaround as I did for ConstraintDescriptor, or simply drop support for 4.3.1. In both cases, I’m gonna merge this feature.

I’m quite busy this weekend, so I’ll look at it next week.

@lread
Copy link
Contributor Author

lread commented May 20, 2014

Ah, HV 4.3.1 - didn't notice that, glad that Travis did! I personally don't have a need for HV 4.3.1 compatibility.

@jirutka
Copy link
Owner

jirutka commented May 26, 2014

I’ve just merged your PR and released 2.1.2 (it’ll be in Maven Central soon). Thank you again and sorry for long delay!

@jirutka jirutka closed this May 26, 2014
@lread
Copy link
Contributor Author

lread commented May 28, 2014

Sweet! Thanks for merging it in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants