-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ST4 - Line annotation background color looks ugly #552
Comments
@deathaxe I've just updated to ST4 and I am still having this issue. I probably overlooked something, but could you tell me how to fix that? Another question is, why the text is so indented to the right if compared to the SBT3 version: I have removed the commit has from the annotations although this didn't help much. EDIT: In both cases I have the default option Support Info
|
The GitGutter uses normal phantoms when running with ST3. They suffer some edge cases with soft wrapped lines. SublimeHQ's solution for this issue is a new feature called "annotations" in ST4. These are phantoms located at the very right edge of a view, which optionally create popups when hovering. A plugin can't control the location nor the amount of text being displayed. The It may be required to close and reopen a view or restart ST to make some of those settings apply after a change as GitGutter caches many of them to avoid creating required templates after every key press. As those settings don't change frequently I haven't put any effort into fixing those caching edge cases. |
@deathaxe Thank you for taking your time to answer my questions. I understood the part about PS: I still prefer GitGutter over the incremental diff ❤️ |
The background color is hardcoded. You could have a look at the commits and patch the files yourself. As most recent ST4 is able to handle |
Now I got it, thanks. I will play myself and probably let you know (probably tomorrow or later this week) in this thread |
Description
With the newest version of GitGutter the line annotations for ST4 use the background color of the current color scheme, but this looks ugly when using the
"highlight_line": true
option.I propose either the background be set back to transparent (as it is in ST3) or have it be configurable in the same way the foreground is:
Support Info
The text was updated successfully, but these errors were encountered: