Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: line annotation display events #529

Closed
wants to merge 1 commit into from
Closed

Conversation

deathaxe
Copy link
Collaborator

@deathaxe deathaxe commented Nov 8, 2018

This commit makes some changes to the event handler, which is responsible to
call git blame and display line annotations.

The origin for the changes is issue #528. Even though the issue could not be
reproduced on Windows a couple possible enhancements were identified.

Fixes

  1. Fail silently if the active row can't be identified because of an invalid
    or empty selection object returned by ST API.

Enhancements:

  1. Hide line annotation if...
    a) multiple cursors are active
    b) selection is not empty
    c) caret is moved vertically in row

    As a result line annotation is displayed only if a single cursor is moved
    to a new unmodified line of text, if word wrap is disabled.

    This should help improving the editing experience and reduce the impact of
    some of the phantoms' drawbacks / limitations.

  2. All checks are performed within the debounced code to avoid the line
    annotation to flicker up if text is selected via mouse.

This commit makes some changes to the event handler, which is responsible to
call git blame and display line annotations.

The origin for the changes is issue #528. Even though the issue could not be
reproduced on Windows a couple possible enhancements were identified.

Fixes

1. Fail silently if the active row can't be identified because of an invalid
   or empty selection object returned by ST API.

Enhancements:

1. Hide line annotation if...
   a) multiple cursors are active
   b) selection is not empty
   c) caret is moved vertically in row

   As a result line annotation is displayed only if a single cursor is moved
   to a new unmodified line of text, if word wrap is disabled.

   This should help improving the editing experience and reduce the impact of
   some of the phantoms' drawbacks / limitations.

2. All checks are performed within the debounced code to avoid the line
   annotation to flicker up if text is selected via mouse.
@rwols
Copy link

rwols commented Nov 9, 2018

Hi @deathaxe, I just checked out this branch and it makes the exception disappear. Nice work!

@deathaxe deathaxe closed this Nov 9, 2018
@deathaxe deathaxe deleted the pr/fix-528 branch November 9, 2018 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants