Allow debugger when it is in another context.

We only want to catch debugger when it is being used as a debugger statement. Not when it is in commments, or quotes, or any other intended use.
jish · Jun 11, 2014 · d144398 · d144398
1 parent 214e861
commit d144398
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/lib/plugins/pre_commit/checks/debugger.rb b/lib/plugins/pre_commit/checks/debugger.rb
@@ -13,7 +13,7 @@ def message
       end
 
       def pattern
-        'debugger'
+        '-e "^[ 	]*debugger"'
       end
 
       def self.description

diff --git a/test/files/debugger_file.rb b/test/files/debugger_file.rb
@@ -1,5 +1,5 @@
 class DebuggerFile
   def blam
-    debugger
+  	debugger
   end
 end
diff --git a/test/files/valid_file.rb b/test/files/valid_file.rb
@@ -2,6 +2,9 @@
 
 # class docs for rubocop
 class ValidFile
+
+  # Comments with the word: debugger should be allowed
   def no_problems_here!
   end
+
 end
diff --git a/test/unit/plugins/pre_commit/checks/debugger_test.rb b/test/unit/plugins/pre_commit/checks/debugger_test.rb
@@ -23,7 +23,7 @@
   it "fails if file contains debugger" do
     subject.call([fixture_file('debugger_file.rb')]).must_equal(<<-EXPECTED)
 debugger statement(s) found:
-test/files/debugger_file.rb:3:    debugger
+test/files/debugger_file.rb:3:  	debugger
 EXPECTED
   end