improved shell handling #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jish so how do you like it? I have few more other PRs waiting also ;) |
| options = args.last.is_a?(::Hash) ? args.pop : {} | ||
| args = build_command(*args) | ||
| execute_raw(args, options) | ||
| end |
There was a problem hiding this comment.
Seems cleaner in all of the check files. Any reason not to use Open3 anymore?
There was a problem hiding this comment.
with Open3 we get separate stdout from stderr, with the 2>&1 it's merged properly, even if it is possible to get it ordered properly with open3 - it would take more code to that, less code has to be better ;)
|
@jish did you had time to review it further? |
Conflicts: lib/plugins/pre_commit/checks/coffeelint.rb lib/plugins/pre_commit/checks/scss_lint.rb lib/pre-commit/checks/grep.rb
|
merged master after #146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.