Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest pluginator version to fix bug with bundler 1.15 #259

Merged
merged 1 commit into from
Jun 12, 2017

Conversation

mpapis
Copy link
Collaborator

@mpapis mpapis commented May 25, 2017

Fixes #258

@mpapis mpapis requested a review from jish May 25, 2017 09:53
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.2%) to 92.105% when pulling 1a6a027 on bugfix/update_pluginator into f7bb995 on master.

@mpapis
Copy link
Collaborator Author

mpapis commented May 25, 2017

interesting, the tests fail only when ran via rake

@mpapis
Copy link
Collaborator Author

mpapis commented Jun 6, 2017

the tests fail because one of the loaded tests is detected as a plugin, I hope to work on it today, but it should be safe to merge & release right away, I will release a new version with fix for tests soon

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.263% when pulling cb594c3 on bugfix/update_pluginator into f7bb995 on master.

@mpapis
Copy link
Collaborator Author

mpapis commented Jun 12, 2017

@jish it's fixed now with 1.5.0

@jish
Copy link
Owner

jish commented Jun 12, 2017

Thanks!

@jish jish merged commit 6264252 into master Jun 12, 2017
@jish jish deleted the bugfix/update_pluginator branch June 12, 2017 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants