Enhanced debugging features: #870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Log request uri in server request handler for log level debug. I prefer to log this level info in mny fork because it enables quick diagnosis when my Alexa speech skill has misheard what I said. But doing it on debug level is more consistent with the original program. 2. Add /loglevel get request which implements ability to change the process NODE_LOG_LEVEL (one of trace, debug, info, warn, or error (and off which is a synonym for error)). Document the command in static doc content. This is very useful when the code is running in a container. Especially if you add it to your alexa skill as I have.
add apple music playlist support
jishi
reviewed
Apr 17, 2023
|
|
||
|
|
||
| // Change node environment log level on request. | ||
| if (/^\/loglevel\/.+$/.test(req.url)) { |
There was a problem hiding this comment.
This could be simplified with req.url.startsWith('/loglevel/'), no need for a regexp.
| @@ -14,7 +14,8 @@ const discovery = new SonosSystem(settings); | |||
| const api = new SonosHttpAPI(discovery, settings); | |||
|
|
|||
| var requestHandler = function (req, res) { | |||
| req.addListener('end', function () { | |||
| logger.debug(`request: ${req.url}`); | |||
| req.addListener('end', function () { | |||
There was a problem hiding this comment.
Wrong indentation, it's two spaces.
| let param = params[1]; | ||
| switch (param) { | ||
| case 'off': | ||
| param = 'error'; |
There was a problem hiding this comment.
Hm, I don't follow what off would actually set. I would also like that just getting /loglevel would actually return the current loglevel.
fix: use correct variable for shuffle response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log request uri in server request handler for log level debug. I prefer to log this level info in mny fork because it enables quick diagnosis when my Alexa speech skill has misheard what I said. But doing it on debug level is more consistent with the original program.
Add /loglevel get request which implements ability to change the process NODE_LOG_LEVEL (one of trace, debug, info, warn, or error (and off which is a synonym for error)). Document the command in static doc content.
This is very useful when the code is running in a container. Especially if you add it to your alexa skill as I have.