Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for tracing unstable composables #99

Open
jisungbin opened this issue Feb 24, 2024 · 1 comment · Fixed by #102 · May be fixed by #172
Open

Support for tracing unstable composables #99

jisungbin opened this issue Feb 24, 2024 · 1 comment · Fixed by #102 · May be fixed by #172
Labels
enhancement New feature or request

Comments

@jisungbin
Copy link
Owner

jisungbin commented Feb 24, 2024 •
edited
Loading

Composables with unstable arguments need to be handled differently because of the way IRs are generated.
@jisungbin jisungbin added the bug Something isn't working label Feb 24, 2024
@jisungbin jisungbin self-assigned this Feb 24, 2024
@jisungbin jisungbin changed the title Not being handled as an AffectField when all arguments are unstable Not being handled as an AffectField when some argument is unstable Feb 24, 2024
jisungbin added a commit that referenced this issue Feb 24, 2024
@jisungbin
Resolves #99
e896b5d
@jisungbin jisungbin mentioned this issue Feb 24, 2024
Merged
@jisungbin jisungbin changed the title Not being handled as an AffectField when some argument is unstable Composables that contain unstable parameters have parameter change tracking disabled Feb 24, 2024
jisungbin added a commit that referenced this issue Feb 24, 2024
@jisungbin
Enable parameter change tracking for composables with unstable parame…
7cc4be9 
…ters (#102)

Resolves #99.
@jisungbin
Copy link
Owner Author

jisungbin commented Mar 4, 2024 •
edited
Loading

#102 implementation is very naive and not guaranteed to be durable. Unstable composables are always recomposed, so I should reimplement this differently.

@jisungbin jisungbin reopened this Mar 4, 2024
@jisungbin jisungbin changed the title Composables that contain unstable parameters have parameter change tracking disabled Support for tracking unstable composables Mar 10, 2024
@jisungbin jisungbin added enhancement New feature or request and removed bug Something isn't working labels Mar 10, 2024
@jisungbin jisungbin removed their assignment Mar 10, 2024
@jisungbin jisungbin linked a pull request Jun 17, 2024 that will close this issue
Draft
@jisungbin jisungbin changed the title Support for tracking unstable composables Support for tracing unstable composables Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@jisungbin