Add support for Signing out: #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Keep all the features of Response Class 2. Extract part of code of Response into BaseReponse Class, from which Response inherits 3. Define SignoutResponse, which inherits from BaseResponse 4. Define SignoutRequest to support create request for signing out
|
@alex-jitbit will this eventually be merged, or is it out of scope? |
kalluu-ck
reviewed
Jan 14, 2022
|
|
||
| public string GetLogoutStatus() | ||
| { | ||
| XmlNode node = _xmlDoc.SelectSingleNode("/samlp:LogoutResponse/samlp:Status/samlp:StatusCode"); |
There was a problem hiding this comment.
I have to add the _xmlNameSpaceManager as following, otherwise it will throw error "Namespace Manager or XsltContext needed. This query has a prefix, variable, or user-defined function."
XmlNode node = _xmlDoc.SelectSingleNode("/samlp:LogoutResponse/samlp:Status/samlp:StatusCode", _xmlNameSpaceManager);
|
Any update on this? I need this for my solution if you can provide it. |
|
Yes, I will include this, however, becasue the project is now a full-fldged nuget library, I will transfer this code manually, hope I'll get to this next week. |
|
@alex-jitbit any update on this? |
|
Moved changes to #81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Response inherits