Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENABLE_HTTP_REDIRECT=0 does not disable HTTPS redirect #30

Closed
SimmyD opened this issue Nov 20, 2018 · 8 comments
Closed

ENABLE_HTTP_REDIRECT=0 does not disable HTTPS redirect #30

SimmyD opened this issue Nov 20, 2018 · 8 comments

Comments

@SimmyD
Copy link

SimmyD commented Nov 20, 2018

When creating a fresh docker instance when setting ENABLE_HTTP_REDIRECT=0 in the .env file the if else statement doesn't seem to be working in web/rootfs/defaults/default.

In my install "return 301 https://$host$request_uri;" was placed there instead of "include /config/nginx/meet.conf;"

manually changing this worked

@sapkra
Copy link
Contributor

sapkra commented Nov 20, 2018

You have to leave the environment variable empty. 😉

@saghul
Copy link
Member

saghul commented Nov 28, 2018

Setting it to 0 should work as expected, so I'll treat this as a bug and try to find a way to make it work. As @sapkra said, you can just omit it for the time being.

@sapkra
Copy link
Contributor

sapkra commented Nov 28, 2018

0 should work but I think environment variables are always strings so the go template engine detects an array of one char and this is true

@saghul saghul closed this as completed in 30c4258 Jan 28, 2019
netaskd added a commit to netaskd/docker-jitsi-meet that referenced this issue Apr 23, 2019
@dgruss
Copy link

dgruss commented May 25, 2020

I've been using jitsi meet behind an https proxy for a while but this stopped working after updating to current master.

Tried
#ENABLE_HTTP_REDIRECT=...
ENABLE_HTTP_REDIRECT=0
ENABLE_HTTP_REDIRECT="0"
ENABLE_HTTP_REDIRECT=

None worked... always 301.

I manually edited the generated nginx.conf in the container -> then it works again... not sure what went wrong there...

@saghul
Copy link
Member

saghul commented May 25, 2020

Have you wiped the config volume after changing the env file?

@dgruss
Copy link

dgruss commented May 26, 2020 via email

@saghul
Copy link
Member

saghul commented May 26, 2020

Yes, on the README (which is now moved into the handbook): https://jitsi.github.io/handbook/docs/devops-guide/devops-guide-docker#configuration (see the important note)

@dgruss
Copy link

dgruss commented May 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants