JWT Sign Type Fixing (#1771)

[DevelopingEntitiesWithFuntations]

Added and exposed the required env variable.

[saghul]

I'm not sure "null" as a string will work, we need to check that.

[DevelopingEntitiesWithFuntations]

Ok, please do.

[DevelopingEntitiesWithFuntations]

Is possible to run a CI/CD pipeline to test that?

[saghul]

Alas there is no CI for that :-/

Your change is not going to work though. It will set it to the string "null". And this is what the module code does: https://github.com/jitsi/jitsi-meet/blob/38be09fc5486979ad554d834702cabbaf5062cc0/resources/prosody-plugins/token/util.lib.lua#L100

So I think the way forward is to only set that config option is actually set, and provide no default.

[DevelopingEntitiesWithFuntations]

@saghul what if we take nil instead of null? 🤔

[saghul]

You still have the quotes problem.

[DevelopingEntitiesWithFuntations]

@saghul then remove the quotes?...

Alternatively, perhaps error out if no value is set otherwise continue?

[saghul]

Just add a condition and set it to whatever value the env var has, if it's set.

[DevelopingEntitiesWithFuntations]

Let me get this straight - so I need to open up another PR on the Jitsi Meet GitHub to fix this and after that is merged you may merge this PR afterwards?

[saghul]

No, you can fix it right here. Just do (pseudocode): if .Env.FOO then the_setting = {{ .Env.FOO }}

So don't set it unconditionally, thus preserving the default value, if the user didn't set it.

[DevelopingEntitiesWithFuntations]

Don't if conditions require unnecessary computation power and should be avoided for such cases?

I think I did what you wanted - {{ $JWT_SIGN_TYPE := .Env.JWT_SIGN_TYPE | default "RS256" -}}

[DevelopingEntitiesWithFuntations]

Or you want smth like?:

{{- if .Env.JWT_SIGN_TYPE }}
{{ $JWT_SIGN_TYPE := .Env.JWT_SIGN_TYPE }}

[DevelopingEntitiesWithFuntations]

or you want an or case with a default value?

[saghul]

No. DONT declare the auxiliary variable now, you can just if the declaration of the actual prosody variable.

[DevelopingEntitiesWithFuntations]

I don't quite get you. Like this on Line 138 (my version)?:

{{ if .Env.JWT_SIGN_TYPE }}
    signature_algorithm = "{{ $JWT_SIGN_TYPE }}"
else
    signature_algorithm = "RS256"

[saghul]

Almost. Don't set signature_algorithm at all if the env car is not defined.

[DevelopingEntitiesWithFuntations]

So just the first two lines from the example above then?:

{{ if .Env.JWT_SIGN_TYPE }}
    signature_algorithm = "{{ $JWT_SIGN_TYPE }}"

[saghul]

Yes!

[DevelopingEntitiesWithFuntations]

Please review this and merge if it's correct ^^