Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen sharing with Electron that load url #325

Closed
khoneb opened this issue Feb 8, 2023 · 0 comments · Fixed by #369
Closed

Screen sharing with Electron that load url #325

khoneb opened this issue Feb 8, 2023 · 0 comments · Fixed by #369

Comments

@khoneb
Copy link

khoneb commented Feb 8, 2023

Hi everyone.

I developed a small Electron Dekstop application that handle's login on my webapp and then "load" the webapp through an Electron loadUrl().

We already implemented Jitsi meet in that webapp (with specific UI etc). Everything works fine except the screen sharing.
(The first development was years ago, and since Electron did not allowed custom chrome extension we just didn't bother to make the screen sharing work).

Since then a lot of changes happened and it seems like this project managed to make it work.

I am aware of the solution that allows electron to use the jitsi screen sharing through @jitsi/electron-sdk but i'm wondering whether a solution exists in my case (AKA Jitsi not being implemented directly in Electron, but through a loadUrl()).

Is there a chrome extension that I could add to my electron project allowing chromium to get the JitsiMeetElectron.obtainDesktopStreams function ?

Or is the only solution to implement from scratch jitsi in our Electron project ?

Thanks in advance.

saghul added a commit that referenced this issue Jan 16, 2024
We may fail to access the iframe's contentWindow, but we can ignore that
since the new hook doesn't require it.

Fixes: #368
Fixes: #325
@saghul saghul closed this as completed in 6f0f561 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant