Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conference: check if valid jitsi-meet server #62

Closed
akshitkrnagpal opened this issue Jun 23, 2018 · 3 comments
Closed

conference: check if valid jitsi-meet server #62

akshitkrnagpal opened this issue Jun 23, 2018 · 3 comments

Comments

@akshitkrnagpal
Copy link
Contributor

akshitkrnagpal commented Jun 23, 2018

It would be nice if we can check if the given domain from settings or from the link is a valid domain and display an error if not.

Currently, it goes back to the Welcome page.

If https://${domain}/external_api.js exists, the server is valid jitsi-meet server. Does this sound good?

@saghul
Copy link
Member

saghul commented Jun 23, 2018

If https://${domain}/external_api.js exists, the server is valid jitsi-meet server. Does this sound good?

This sounds great indeed! I think we could do a HEAD request using fetch() to avoid downloading the file. OTOH, it's ok if we download the file because it will be cached and used later anyway.

@akshitkrnagpal
Copy link
Contributor Author

I think we could do a HEAD request using fetch() to avoid downloading the file.

Yeah. I wanted to use this as checking is the default domain is valid or not. It will only get updated if valid and restore it to the previous value or meet.jit.si if not.

we download the file because it will be cached and used later anyway.

That's only valid if we check that in Conference component, which we will also have to do. But it can be handled by onerror function of the script tag. Error showing can be done with a loading screen.

@saghul
Copy link
Member

saghul commented Jun 23, 2018

Yeah. I wanted to use this as checking is the default domain is valid or not. It will only get updated if valid and restore it to the previous value or meet.jit.si if not.

👍

That's only valid if we check that in Conference component, which we will also have to do. But it can be handled by onerror function of the script tag. Error showing can be done with a loading screen.

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants