refactor: reduce shipped and installed size #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csett86
changed the title
csett86
force-pushed
the
slim-release
branch
3 times, most recently
from
7b03ea6
to
92d43be
Compare
csett86
changed the title
|
@saghul FYI: I would merge these PRs myself (or directly push to master) after successful testing to help you with maintenance, but unfortunately thats rejected for contributors with the current permission setup for this repo. |
This moves all webpacked deps to be automatically included from the asar and thus reduces the shipped binary by 14MB on Windows, 16 MB on Mac and 12MB on Linux. The installed size on mac is reduced by 105 MB. Previously all the dependencies were webpacked and minified in the asar in the build folder and in its full installed version unused under node_modules. Only keep the dependencies that are externally required in the node-modules folder. Signed-off-by: Christoph Settgast <csett86@web.de>
|
@saghul I have tested this successfully on windows, mac and linux. Please approve if you agree to the approach |
saghul
approved these changes
Jun 27, 2021
Merged
d3473r
pushed a commit
to d3473r/jitsi-meet-electron
that referenced
this pull request
Sep 1, 2023
This moves all webpacked deps to be automatically included from the asar and thus reduces the shipped binary by 14MB on Windows, 16 MB on Mac and 12MB on Linux. The installed size on mac is reduced by 105 MB. Previously all the dependencies were webpacked and minified in the asar in the build folder and in its full installed version unused under node_modules. Only keep the dependencies that are externally required in the node-modules folder. Signed-off-by: Christoph Settgast <csett86@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all webpacked deps to be automatically included from the asar
and thus reduces the shipped binary by 14MB on Windows, 16 MB on Mac and
12MB on Linux. The installed size on mac is reduced by 105 MB.
Previously all the dependencies were webpacked and minified in the asar in the
build folder and in its full installed version unused under node_modules.
Only keep the dependencies that are externally required in the node-modules
folder.
Signed-off-by: Christoph Settgast csett86@web.de