refactor: remove dependency to deprecated remote module #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the remote module will be removed from electron 14 onwards, so replace the locale detection with native browser api that is available in the renderer. Signed-off-by: Christoph Settgast <csett86@web.de>
|
@saghul FYI: I would merge these PRs myself (or directly push to master) after successful testing to help you with maintenance, but unfortunately thats rejected for contributors with the current permission setup for this repo. |
csett86
changed the title
|
@saghul I have tested this successfully, please approve if you agree to this small deprecation fix. |
saghul
approved these changes
Jun 27, 2021
Merged
d3473r
pushed a commit
to d3473r/jitsi-meet-electron
that referenced
this pull request
Sep 1, 2023
the remote module will be removed from electron 14 onwards, so replace the locale detection with native browser api that is available in the renderer. Signed-off-by: Christoph Settgast <csett86@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the remote module will be removed from electron 14 onwards,
so replace the locale detection with native browser api that
is available in the renderer.
Signed-off-by: Christoph Settgast csett86@web.de