Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lockscreen appearance #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

silvanfischer
Copy link
Contributor

@silvanfischer silvanfischer commented Feb 13, 2024

The keyguard should not be dismissed on these screen as it could cause the opposite and add the keyguard again to these screens. showOnLockScreen is actually enough to make it appear.

@saghul
Copy link
Member

saghul commented Feb 13, 2024

Thanks for the patch! Can you please go a bit into the details on what you are fixing and how?

@Holofox
Copy link

Holofox commented Mar 6, 2024

@saghul, i think the fix is to be able to show [WrapperJitsiMeetActivity] on locked screen. Now if you try to open [WrapperJitsiMeetActivity] when the screen is locked, the user will not see it. This is necessary when we want to show a full-screen notification and connect the user to a call. Now we get the opposite effect, when we try to open [WrapperJitsiMeetActivity], the screen will lock.

@silvanfischer, i see code formatting in some places, I think we need to remove unnecessary changes and focus on the problem.

@saghul
Copy link
Member

saghul commented Mar 6, 2024

Got it.

Indeed please skip the unnecessary formatting changes and we can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants