Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support port which not default to 443 #282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vipcxj
Copy link
Contributor

@vipcxj vipcxj commented May 27, 2020

IFrameAPITest failed because the wrong port. This pull request make test work on the host with a port other than 443, such as 8080.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@vipcxj
Copy link
Contributor Author

vipcxj commented May 27, 2020

FilmstripOnlyTest#testDisplaysDeviceSelection also failed, too. I dig into it and found APP_ID is undefined. and window.location.search and window.location.params are all empty. but a url with config hash(https://localhost:8080/XXX#interfaceConfig.filmStripOnly=true) works well, FilmstripOnlyTest#testLoadsOnlyTheFilmstrip success and the OnlyTheFilmstrip page shows.

@Neustradamus
Copy link

@damencho: Can you look this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants