Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix ID is deformed in chat if colon is followed by chars that are relatet to smileys #10936

Closed
tigexplorer opened this issue Feb 9, 2022 · 7 comments · Fixed by #14492
Closed
Assignees

Comments

@tigexplorer
Copy link

Description:

Steps to reproduce:

  1. Paste a Matrix ID like @name:singledomain.org in the chat entry and hit enter

Expected behavior:

The ID should not changed

Actual behavior:

The ID is malformed on two lines with a smiley
Auswahl_008

Server information:

  • Jitsi Meet version:
  • Operating System:

Client information:

  • Browser / app version: 2022.1
  • Operating System: ubuntu 20.4

Additional information:

@tigexplorer tigexplorer changed the title Matrix ID is deformed in chat if colon is followed by smiley relatet chars Matrix ID is deformed in chat if colon is followed by chars that are relatet to smileys Feb 9, 2022
@gpatel-fr
Copy link

As a workaround you can prefix your string with the magic string 'https' :-)

Copy link

github-actions bot commented Jan 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 7, 2024
@haansn08
Copy link

haansn08 commented Jan 9, 2024

Another great workaround is to use proper internet standards like XMPP, instead of custom protocols by some startup, that for some reason must reinvent not only XMPP but also how URIs work.

@github-actions github-actions bot removed the stale label Jan 10, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 11, 2024
@csett86
Copy link
Member

csett86 commented Mar 11, 2024

Still relevant

@saghul
Copy link
Member

saghul commented Mar 11, 2024

I doubt anyone on our side is going to fix this, FWIW. Patches are welcome though!

@github-actions github-actions bot removed the stale label Mar 12, 2024
@csett86
Copy link
Member

csett86 commented Mar 17, 2024

As my matrix server starts with the letter "s" and thus I am affected by this, I may give it a try to fix this

csett86 added a commit that referenced this issue Mar 17, 2024
Matrix user ids all start with an @, so lets skip these for the
smiley renderer (same as we already do for any url-like strings).

I did not use "contains @ and :", as also the :@ (shorthand for 😡)
contains that and would have broken it...

Fixes: #10936
@csett86 csett86 self-assigned this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants