Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Join Meeting with Prosody Reservations on Docker #11623

Closed
Mahdhir opened this issue Jun 6, 2022 · 1 comment
Closed

Unable to Join Meeting with Prosody Reservations on Docker #11623

Mahdhir opened this issue Jun 6, 2022 · 1 comment

Comments

@Mahdhir
Copy link

Mahdhir commented Jun 6, 2022

Description:

Steps to reproduce:

  1. set PROSODY_RESERVATION_ENABLED=true in .env
  2. set PROSODY_RESERVATION_REST_BASE_URL=<your-reservations-api-url>
  3. Join meeting on hosted jitsi server

Expected behavior:

Join Call as usual. Reservation API should be hit with calls from Jitsi Server.

Actual behavior:

When Join Meeting button is clicked, nothing happens on the UI. When checking the prosody logs, the error given is,

c2saaabf9af8e30                                              error      Traceback[c2s]: /prosody-plugins/mod_reservations.lua:349: attempt to concatenate a table value (upvalue 'api_prefix')
        stack traceback:
        /prosody-plugins/mod_reservations.lua:349: in method 'call_api_create_conference'
        /prosody-plugins/mod_reservations.lua:239: in method 'enqueue_or_route_event'
        /prosody-plugins/mod_reservations.lua:559: in field '?'
        /usr/share/lua/5.4/prosody/util/events.lua:81: in function </usr/share/lua/5.4/prosody/util/events.lua:77>
        (...tail calls...)
        /usr/share/lua/5.4/prosody/core/stanza_router.lua:184: in upvalue 'core_post_stanza'
        /usr/share/lua/5.4/prosody/core/stanza_router.lua:128: in upvalue 'core_process_stanza'
        /usr/lib/prosody/modules/mod_c2s.lua:326: in upvalue 'func'
        /usr/share/lua/5.4/prosody/util/async.lua:144: in function </usr/share/lua/5.4/prosody/util/async.lua:142>

image

Server information:

  • Jitsi Meet version: Jitsi Docker Master
  • Operating System: Oracle Linux 8

Client information:

  • Browser / app version: Chrome
  • Operating System: Windows 10
@shawnchin
Copy link
Contributor

Looks like a bug in the docker setup. See https://github.com/jitsi/docker-jitsi-meet/pull/1301/files#r889947361

Mahdhir added a commit to Mahdhir/docker-jitsi-meet-prosody-fix that referenced this issue Jun 6, 2022
brajendrak00068 added a commit to SariskaIO/docker-jitsi-meet that referenced this issue Aug 26, 2022
* prosody: enable limits

* feat: Enables limits with default values from upstream.

* feat: Enables limits_exception module and adding jicofo and jvb.

Removes the limits for the jicofo and jvb connections.

* release: stable-5963

* 6f6fe77 prosody: enable limits
* db3d790 prosody: fix: restrict room creation to jicofo (jitsi#1059)
* 281db36 misc: working on latest

* misc: working on latest

* web: fix acme.sh pre and post hooks

Fixes: jitsi#114

* prosody: add domain mapper options to default configuration

* prosody: add ability to configure external TURN server

Co-authored-by: Thomas Butter <tbutter@gmail.com>

* prosody: add support for A/V Moderation

Set ENABLE_AV_MODERATION to 1 in order to enable it.

NOTE: This feature is still under development and should be considered
beta quality.

* release: stable-6173

* c95f0d6 prosody: add support for A/V Moderation
* 856e414 prosody: add ability to configure external TURN server
* bcae3b1 prosody: add domain mapper options to default configuration
* cf90461 web: fix acme.sh pre and post hooks
* 65563d9 misc: working on latest

* misc: working on latest

* misc: remove quotation marks from TURN configuration (jitsi#1111)

Fixes: jitsi#1110

* jicofo: fix boolean values in configuration file

A type error is thrown when one of these environment variables is
defined:
- ENABLE_AUTO_OWNER
- JICOFO_ENABLE_HEALTH_CHECKS
- JICOFO_ENABLE_BRIDGE_HEALTH_CHECKS

* web: recreate interface_config.js on container restart

Recreate interface_config.js on container restart if custom-interface_config.js exists

* web: remove no longer needed code

The toolbar buttons have moved to config.js and are commented out by default.

* jicofo: add enable-auto-login config option

* web: persist crontabs for letsencrypt

* web: add env variables for configuring vp9

* misc: cleanup Dockerfiles

* Cleanup: Use spaces instead of tabulation

* Cleanup: Reduce layers

* Cleanup: Homogeneise wget syntax

* Cleanup: Use binary GPG key format

* misc: add support for sentry logging

* web: add config options for polls and reactions

* prosody: simplify code

We no longer need to use token based auth (but allow empty tokens) when
WebSockets are used.

* web: regenerate interface_config.js on every boot

Customization is still available via custom-interface_config.js. This
way we will slowly get rid of the deprecated interface_config.js as all
options move to config.js.

* misc: fix/ improve shebang compatibility

* misc: enable features by default

- prejoin screen
- lobby
- av moderation
- talk while muted detection
- reactions

* base-java: update to Java 11

Jigasi will remain wiith Java 8 for the moment.

* jibri: uppdate Chrome to version 94

* jibri: allow graceful shutdown of the container

* jvb: use modern config for ice4j

* jibri: use new configuration file

* jibri: default to recording in 720p

* jvb: remove unneeded alias

* compose: changed REACTIONS env variable name in docker-compose file

* jvb: add ability to configure the shutdown API

* examples: move to jitsi-contrib

* jvb: try to use the correct IP as the default server ID

This hopefully fixes WS issues on environment with multiple networks
such as Docker Swarm.

* release: stable-6433

* 487bcca jvb: try to use the correct IP as the default server ID
* 9e982fe examples: move to jitsi-contrib
* 192a623 jvb: add ability to configure the shutdown API
* 5dcf7b4 compose: changed REACTIONS env variable name in docker-compose file
* d94f4b6 jvb: remove unneeded alias
* 7cd71a2 jibri: default to recording in 720p
* bee4b6a jibri: use new configuration file
* 76a16a8 jvb: use modern config for ice4j
* 18ac85b jibri: allow graceful shutdown of the container
* 3c19ed6 jibri: uppdate Chrome to version 94
* b858b37 base-java: update to Java 11
* 2061b86 misc: enable features by default
* 343062b misc: fix/ improve shebang compatibility
* ff8c1c2 web: regenerate interface_config.js on every boot
* bda1502 prosody: simplify code
* cfd8d3c web: add config options for polls and reactions
* 537fcd5 misc: add support for sentry logging
* be1da0e misc: cleanup Dockerfiles
* 09cf0a8 web: add env variables for configuring vp9
* 3df32d9 web: persist crontabs for letsencrypt
* f748484 jicofo: add enable-auto-login config option
* 96419ba web: remove no longer needed code
* 1835d65 web: recreate interface_config.js on container restart
* b555d41 jicofo: fix boolean values in configuration file
* 6be198c misc: remove quotation marks from TURN configuration (jitsi#1111)
* 407a98d misc: working on latest

* misc: working on latest

* env:  fix unexpected character bug with recent docker desktop

This prevents the following parsing errors in recent Docker Desktop app:

- unexpected character "!" in variable name near "to Web Chat!\\n\\n...
- respectively: unexpected character "-" in variable name near "super-light-editor light-background full-width-editor...

Co-authored-by: Werner Fleischer <70745309+wernf@users.noreply.github.com>

* base: update base images to Debian Bullseye

* web,prosody: add breakout rooms support

Co-authored-by: Saúl Ibarra Corretgé <saghul@jitsi.org>

* jicofo: Handle special characters in password

Add quotations to jicofo run script.

This fixes jitsi#488 where jicofo fails to start due to special characters. For
example, if the JICOFO_AUTH_PASSWORD variable value contains `&` or `#` then the
run script fails because the characters are interpreted by bash rather than as a
string.

Note that the `gen-passwords.sh` script does _not_ trigger this issue because it
does not generate characters outside the ASCII alpha-numeric range. This only
shows up when using other tools to generate the password values that do include
special characters in the output or when setting the password values by hand.

* jvb: remove deprecated option

It was only used for REST after internal JVB changes, and it can now be
enabled with the dedicated COLIBRI_REST_ENABLED env var.

* release: stable-6726

* e9275d5 jvb: remove deprecated option
* f40a8d5 jicofo: Handle special characters in password
* 6f56e5b web,prosody: add breakout rooms support
* 3208296 base: update base images to Debian Bullseye
* b02a689 env:  fix unexpected character bug with recent docker desktop
* b5dbfa0 misc: working on latest

* misc: working on latest

* sample: add  ENABLE_BREAKOUT_ROOMS to env.example

* prosody: add missing package libldap-common

* jibri: update Chrome to version 96

* release: stable-6726-1

* 9ac7b59 jibri: update Chrome to version 96
* fb2326e prosody: add missing package libldap-common
* 0600ece sample: add  ENABLE_BREAKOUT_ROOMS to env.example
* 6cf0176 misc: working on latest

* misc: working on latest

* jicofo: configure trusted-domains for Jibri if ENABLE_RECORDING is set

* jigasi: allow jigasi guest participants

Co-authored-by: Werner Fleischer <70745309+wernf@users.noreply.github.com>

* jvb: fix resolving XMPP server aliases

Co-authored-by: Daniil Meitis <daniil.meitis@viber.com>

* web: allow configuring buttons in toolbar and pre-join screen

* jvb: make MUC_NICKNAME configurable

* release: stable-6726-2

* ae3e7e7 jvb: make MUC_NICKNAME configurable
* 0be9c8f web: allow configuring buttons in toolbar and pre-join screen
* d9d12f0 jvb: fix resolving XMPP server aliases
* 81dc384 jigasi: allow jigasi guest participants
* a8a596b jicofo: configure trusted-domains for Jibri if ENABLE_RECORDING is set
* d250ad7 misc: working on latest

* misc: working on latest

* doc: update CHANGELOG

* jibri: correct chromedriver mismatch

* jibri: turn on -x so that we can see what is actually executing

* jibri: bail out on the build if the actual release doesn't match the major release

* jibri: ensure the correct chromedriver gets downloaded when CHROME_RELEASE != latest

* jibri: move chrome installation to a separate script

* release: stable-6826

* 238a636 jibri: correct chromedriver mismatch
* 555a40e doc: update CHANGELOG
* 825b4cb misc: working on latest

* misc: working on latest

* env.example : ETHERPAD_PUBLIC_URL : incl. /p/ path

Closes jitsi#1200

* web: configure remote participant video menu

* web: cache versioned static files

Co-authored-by: Werner Fleischer <70745309+wernf@users.noreply.github.com>

* Use the new log formatters, clean up stale logging config.

* release: stable-6865

* 8004ffe Use the new log formatters, clean up stale logging config.
* a862e84 web: cache versioned static files
* 48d499a web: configure remote participant video menu
* 78791ad env.example : ETHERPAD_PUBLIC_URL : incl. /p/ path
* a504b59 misc: working on latest

* misc: working on latest

* chore: add opencontainers labels to Dockerfiles

* misc: add missing quotes to labels in dockerfiles

* misc: fix label order in  dockerfiles

* jvb: remove TCP support

It's not tested at all and has problems. The recommendation is to use a
TURN server for TCP.

* prosody: authentication by matrix user authentication service

Added env variables and prosody plugins to authenticate prosody users by the matrix user authentication service, refer to https://github.com/matrix-org/prosody-mod-auth-matrix-user-verification

Co-authored-by: Markus Münzel <markus@muenzel.de>

* fix: Fixes missing variable for prosody plugins.

* feat: Enables tenants/subdomains by default.

* feat: Enables polls for breakout rooms.

* base: replace frep with tpl

It's our (simplified) fork: https://github.com/jitsi/tpl

* release: stable-7001

* 6e0dd04 base: replace frep with tpl
* 1b51c77 feat: Enables polls for breakout rooms.
* 0b019ee feat: Enables tenants/subdomains by default.
* d50df67 fix: Fixes missing variable for prosody plugins.
* 88997f5 prosody: authentication by matrix user authentication service
* 7a93978 jvb: remove TCP support
* c37706c misc: fix label order in  dockerfiles
* 0de062b misc: add missing quotes to labels in dockerfiles
* 76424fd chore: add opencontainers labels to Dockerfiles
* 3b8ed7e misc: working on latest

* misc: working on latest

* doc: update CHANGELOG

* jvb: forward port 8080 to docker host

* prosody: use a more recent version of luarocks

* prosody: pin to version 0.11 for now

* prosody: update version

Fixes: jitsi#1246

* web: fix Etherpad when using multi-domain

Fixes: jitsi#1242

* prosody: update package version

Use prosody-0.11 which will give us the latest 0.11 release from the upstream Debian repo. 0.12 made it to Debian backports, and we don't want to use that yet.

* web: fix matching etherpad location

To avoid /etherpad/ matched by fallback:
location ~ ^/([^/?&:'"]+)/(.*)$

* ci: dry run Docker builds on PRs

* prosody: update to 0.12

* prosody: add temporary workaround for JWT auth

The previous commit updated Prosody to 0.12 and lua to 5.4. This also
forced us to update luajwtjitsi to the latest version (3.0.0), and we
hadn't landed a necessary fix in time for the stable release, so pick
the right file by hand until the next release.

* release: stable-7210

* 1afa278 prosody: add temporary workaround for JWT auth
* 6fe240a prosody: update to 0.12
* 097558b ci: dry run Docker builds on PRs
* eca5d16 web: fix matching etherpad location
* 3afc1e3 prosody: update package version
* b0617c0 web: fix Etherpad when using multi-domain
* 0ce0f09 prosody: update version
* 201a1b4 prosody: pin to version 0.11 for now
* 29b4c23 prosody: use a more recent version of luarocks
* c5b049a jvb: forward port 8080 to docker host
* 6af7cd8 doc: update CHANGELOG
* dd7b70b misc: working on latest

* misc: working on latest

* prosody: add mod_auth_cyrus from community libraries

Fixes: jitsi#1264

With prosody 0.12 mod_auth_cyrus moved to community repos see: https://prosody.im/doc/release/0.12.0

* prosody: completely disable external components

We are no longer using component connections.

* release: stable-7210-1

* a8e6a34 prosody: completely disable external components
* 8587d29 prosody: add mod_auth_cyrus from community libraries
* 3a070e6 misc: working on latest

* misc: working on latest

* release: stable-7210-2

* 2634e96 misc: working on latest

* misc: working on latest

* jicofo: add optional XMPP_PORT value (jitsi#1275)

* jicofo: add optional XMPP_PORT value

* include compose and env example for XMPP_PORT

* extends use of the XMPP_PORT property

* fix compose to use default

* re-commenting XMPP_PORT value

* include XMPP_PORT in compose for all services

* always use $XMPP_PORT, value defaulted in template

* missing JVB setting

* feature: support multiple XMPP servers via list (jitsi#1276)

* jibri: bump Chrome to version 101

* release: stable-7287

* 41d6a9a jibri: bump Chrome to version 101
* 88bb1bc feature: support multiple XMPP servers via list (jitsi#1276)
* 95af778 jicofo: add optional XMPP_PORT value (jitsi#1275)
* da0a43a misc: working on latest

* misc: working on latest

* web: add more audio quality options

Also replace deprecated stereo option.

* web: add e2eping support using env variables

Also consolidate disable remote video menu using env variables

* misc: add stalebot

* config: simplify configuration

Use default values everywhere so they don't need to be specified in the
.env file.

This makes the default .env file much smaller (the larger config options
are documented in the handbook) and should make it easier to port the
setup to runtimes other than Docker Compose.

* web: remove config option to control FLoC

It has been abandoned by Google. Keep the default opt-out value for a
little longer just in case though.

* web: stop using the default config file

It should be empty and we set all settings. This will reduce the size fo
the file and make it less confusing to inspect on a running system.

* env: add link to handbook

* compose: add ability to change the JVB colibri REST API exposed port

Closes: jitsi#1250

* build,ci: add initial arm64 support

* ci: add GH action docker build caching

* build: add native arch building support

* misc: use the "unstable" tag between releases

In addition the "latest" tag will be gone with the next stable release.

Going forward this is our versioning scheme:

- stable-XXXX: stable release
- unstable: daily unstable rolling release
- unstable-XXXX-YY: daily unstable release

* misc: move security options in sample file

* web,prosody: add support for JaaS components

* misc: update env.example

* misc: define ENABLE_JAAS_COMPONENTS variable (jitsi#1297)

* misc: update dialin numbers url setup (jitsi#1298)

* jicofo,prosody: migrate to new reservations system

It's now implemented in Prosody rather than in Jicofo.

* prosody: fix reservations API

Fixes: jitsi/jitsi-meet#11623

* compose: add ability to override image versions

Useful for local development, overriding to latest is possible now
without changing the compose file itself.

* jibri: update Chrome to M102

* build: adapt release process to multiarch builds

* release: stable-7287-1

* 22e727c build: adapt release process to multiarch builds
* be422c7 jibri: update Chrome to M102
* 1463df4 compose: add ability to override image versions
* 7c29b57 prosody: fix reservations API
* 8337c0b jicofo,prosody: migrate to new reservations system
* 70c5cbf misc: update dialin numbers url setup (jitsi#1298)
* 7790012 misc: define ENABLE_JAAS_COMPONENTS variable (jitsi#1297)
* 62ad172 misc: update env.example
* 74ef7de web,prosody: add support for JaaS components
* 902a673 misc: move security options in sample file
* 2a23095 misc: use the "unstable" tag between releases
* 741ec4a build: add native arch building support
* 68d97c8 ci: add GH action docker build caching
* 8b02b8a build,ci: add initial arm64 support
* 3b86df0 compose: add ability to change the JVB colibri REST API exposed port
* 458515c env: add link to handbook
* 261577c web: stop using the default config file
* ed6ef89 web: remove config option to control FLoC
* cb5a753 config: simplify configuration
* b505d58 misc: add stalebot
* 5ff2735 web: add e2eping support using env variables
* 6284167 web: add more audio quality options
* 515bd19 misc: working on latest

* misc: working on unstable

* build: also release a "stable" tag

* doc: update README

* jibri: fix log location template

* jvb: fix not setting WS server ID

* jibri: add support for arm64

Use Debian's Chromium and ChromeDriver instead of Google's.

This has the limitation of not being able to control the version we
ship, however.

* doc: update README

* prosody: update to latest stable

Prosody 0.12.1 was released, which contained fixes that we needed,
that's why we were running on the 0.12 nightlies.

* build: make sure JITSI_RELEASE is passed when invoking make

* release: stable-7287-2

* ab08247 build: make sure JITSI_RELEASE is passed when invoking make
* 5109874 prosody: update to latest stable
* 343ef56 doc: update README
* 829841e jibri: add support for arm64
* 8d5a9cf jvb: fix not setting WS server ID
* cffab8f jibri: fix log location template
* 94833b5 doc: update README
* d3901ba build: also release a "stable" tag
* 9217b0a misc: working on unstable

* build: fix multiarch build

TARGETPLATFORM must not have a default value.

* misc: working on unstable

* jigasi: switch to Java 11

* jibri: simplify Dockerfile

Slightly reduce layer count by running everything in a single RUN.

Also reduce build time by skipping some unneeded apt update / cleanups.

* jibri: switch to PulseAudio

Using PulseAudio means no longer needing to mount /dev/snd/ which should
make deploying Jibri much easier.

Credits:

https://github.com/openfun/jibri-pulseaudio
https://community.jitsi.org/t/tip-pulseaudio-support-for-jibri/65780
https://github.com/kpeiruza/jitsi-images

* jibri,compose: avoid mounting /dev/shm/

Allocate it with compose.

* web: don't proxy HTTP traffic to WS endpoints

A 405 is returned if there is no upgrade request.

* web,etherpad: fix default public URL

* web: start with clean config.js

* prosody: configure unbound resolver

Fixes: jitsi#1315

* web,jvb: allow underscore in JVB_WS_SERVER_ID

* jigasi: build on arm

* web: add prejoin config options

* jvb: add ability to disable STUN

Fixes: jitsi#1321

* web,jvb: add option to enable multi-stream

* jvb: fix jvb.conf parsing error

* prosody: add ability to configure MUC modules through ENV variables

This allows for configuring how MUC modules can be used.

Closes: jitsi#1310

* release: stable-7439

* ea37859 prosody: add ability to configure MUC modules through ENV variables
* 5ff69fd jvb: fix jvb.conf parsing error
* 8f38fe6 web,jvb: add option to enable multi-stream
* 701dadf jvb: add ability to disable STUN
* 264a3d8 web: add prejoin config options
* fec78e4 jigasi: build on arm
* c04f658 web,jvb: allow underscore in JVB_WS_SERVER_ID
* 55a4591 prosody: configure unbound resolver
* 576e5a9 web: start with clean config.js
* a7f260e web,etherpad: fix default public URL
* 0cbfbfd web: don't proxy HTTP traffic to WS endpoints
* 7ed5063 jibri,compose: avoid mounting /dev/shm/
* fbb8a2d jibri: switch to PulseAudio
* e7533f8 jibri: simplify Dockerfile
* 7e74308 jigasi: switch to Java 11
* a9d1ed6 misc: working on unstable
* b227b73 build: fix multiarch build

* misc: working on unstable

* fix: add missing $ to JIGASI_XMPP_USER

* fix: properly use default SIP config

The default values for JIGASI_SIP_PORT and JIGASI_SIP_TRANSPORT were never used

* prosody: fix XMPP_MUC_CONFIGURATION

* release: stable-7439-1

* 76ff646 misc: working on unstable

* misc: working on unstable

* release: stable-7439-2

* b2f704a misc: working on unstable
* 62655d8 release: stable-7439-1
* 22dc822 prosody: fix XMPP_MUC_CONFIGURATION
* 11de38f fix: properly use default SIP config
* 82a5382 fix: add missing $ to JIGASI_XMPP_USER
* 76ff646 misc: working on unstable

* misc: working on unstable

* etherpad,jigasi: fix compose file version

They all need to match if we want to launch them together.

* prosody: use ENABLE_IPV6 environment variable

Fixes: jitsi#1337

* misc: make ignore rule more generic

* web: add support for wav files to nginx default

Nginx does not define a mime type for wav files by default.  This causes Firefox to refuse to load these files.
Bu adding this mime type, we can ensure that Firefox plays back all interface sounds by default.
Issue is further described in: jitsi/jitsi-meet#11860

* web: add support for brandingDataUrl (jitsi#1346)

Closes: jitsi#1345

* jibri: remove deprecated PulseAudio module

* web: set config.videoQuality.maxBitratesVideo to null if no bitrates are specified

Fixes: jitsi#1318

* web: migrate deprecated recordings options, add some more

* config: migrate depricated recordings options, add localRecording section and disableProfile

* fix: disableProfile

* group recording config, remove boolean conditions

* config add: localRecording extra options

* fixup: template syntax for newly added variables (jitsi#1355)

* prosody: simplify container build

We can now use the Lua libraries packaged in Debian, thus removing the
need for a 2-stage build and manual package coppying.

* release: stable-7577

* b670959 prosody: simplify container build
* e05a9c2 fixup: template syntax for newly added variables (jitsi#1355)
* 164d28b web: migrate deprecated recordings options, add some more
* f126f7a web: set config.videoQuality.maxBitratesVideo to null if no bitrates are specified
* 0364d94 jibri: remove deprecated PulseAudio module
* 1c93e1b web: add support for brandingDataUrl (jitsi#1346)
* 4372717 web: add support for wav files to nginx default
* d804ba4 misc: make ignore rule more generic
* b224131 prosody: use ENABLE_IPV6 environment variable
* be8c41f etherpad,jigasi: fix compose file version
* d7cee00 misc: working on unstable

* misc: working on unstable

* prosody: fix not finding the basexx and cjsson modules

Debian doesn't provide a Lua > 5.2 packaged version for neither.

Fixes: jitsi#1359

* prosody: clean build

Install the jitsi-meet-prosody package instead of uncompressing it.

* release: stable-7577-1

* 20eb991 prosody: clean build
* 6fb422c prosody: fix not finding the basexx and cjsson modules
* 1768164 misc: working on unstable

* misc: working on unstable

* prosody: add missing net-url dependency

It's used by the muc_size plugin.

* prosody: remove explicit dependency

It's a dependency of lua-luaossl.

* release: stable-7577-2

* 55e0eed prosody: remove explicit dependency
* e0bc4e4 prosody: add missing net-url dependency
* e811d7b misc: working on unstable

* misc: working on unstable

* jigasi: temporarily disable G722

Fixes: jitsi#1357

* jigasi: adjust log formatter

* jigasi: fix Sentry test

It's set to 0 by default, cast it to boolean to be sure, just like we do for the other containers.

* prosody: make enable_domain_verification configurable

* web: add new flag for multi-stream

* web: turn on multi-stream by default

* release: stable-7648

* 12941f5 web: turn on multi-stream by default
* 1d4b265 web: add new flag for multi-stream
* 4264f25 prosody: make enable_domain_verification configurable
* 2a7db7c jigasi: fix Sentry test
* 2d106d8 jigasi: adjust log formatter
* 6c9e305 jigasi: temporarily disable G722
* 9edecf2 misc: working on unstable

* misc: working on unstable

* web: fix receiveMultipleVideoStreams flag

* jvb: enable multi-stream by default

* jibri: add ability to enable Dropbox recording without enabling "service recording"

Also add a new ENABLE_LIVESTREAMING env variable to enable live streaming independently from the recording service.

* prosody: add ability to configure max occupants

* jibri: update Chrome to M104

* prosody: fix syntax error

* release: stable-7648-1

* d9921a0 prosody: fix syntax error
* bc6ce20 jibri: update Chrome to M104
* 7c7a43a prosody: add ability to configure max occupants
* 85a38d9 jibri: add ability to enable Dropbox recording without enabling "service recording"
* f8b7037 jvb: enable multi-stream by default
* eb0dd6b web: fix receiveMultipleVideoStreams flag
* 674f134 misc: working on unstable

* misc: working on unstable

* feat: Adds room info http endpoint for jaas components.

* release: stable-7648-2

* 24b6adb feat: Adds room info http endpoint for jaas components.
* 475be2a misc: working on unstable

* misc: working on unstable

* fix: Fixes undefined variable $ENABLE_JAAS_COMPONENTS. Fixes jitsi#1377.

* jibri: fix ENABLE_RECORDING issue

* Fixing ENABLE_RECORDING issue

In jitsi#1372, I made a change to allow the web component to set ENABLE_RECORDING and still enable recording (in order to have "service recording" disabled but Dropbox recording enabled.
I failed to notice that the ENABLE_RECORDING environment variable is also used in Prosody (and in a number of places) as a global switch.

With the new variable semantic (as proposed in jitsi#1372), in order to know if Jibri must be enabled or not, we need 3 variables (ENABLE_RECORDING, DROPBOX_APPKEY and ENABLE_LIVESTREAMING).
This means we should also propagate those variables to Prosody.

To be honest, having the "DROPBOX_APPKEY" forwarded to Prosody just to know if we should enable or disable recording is a bit weird.

So I feel it is a better idea to revert back the meaning of "ENABLE_RECORDING" to be a global switch.

I'm therefore reverting back to old behaviour and adding a new environment variable (ENABLE_SERVICE_RECORDING) that allows turning on or off the "service recording".

* Setting ENABLE_SERVICE_RECORDING default value to ENABLE_SERVICE_RECORDING

* release: stable-7648-3

* 7890183 jibri: fix ENABLE_RECORDING issue
* a2b86a0 fix: Fixes undefined variable $ENABLE_JAAS_COMPONENTS. Fixes jitsi#1377.
* 9f3c81f misc: working on unstable

* misc: working on unstable

* jvb: allow configuration of videobridge.ice.advertise-private-candidates

* jigasi: add ability to disable SIP

* prosody: add jigasi and jibri users as admins

Allows them to bypass auth when tokens are enabled and no empty token is allowed.

* prosody: add missing lua-inspect dependency

* prosody: fix installation of lua inspect module

Sigh Debian!

* release: stable-7648-4

* 6449c60 prosody: fix installation of lua inspect module
* 6664c89 prosody: add missing lua-inspect dependency
* 755bd3f prosody: add jigasi and jibri users as admins
* 8c5fba1 jigasi: add ability to disable SIP
* 4fa0a2f jvb: allow configuration of videobridge.ice.advertise-private-candidates
* 74e5942 misc: working on unstable

* misc: working on unstable

* prosody: add end conference

Co-authored-by: Werner Fleischer <70745309+wernf@users.noreply.github.com>

* jigasi changes

* latest master from origin

Co-authored-by: Дамян Минков <damencho@jitsi.org>
Co-authored-by: Saúl Ibarra Corretgé <s@saghul.net>
Co-authored-by: Bert Driehuis <bert.driehuis+github@gmail.com>
Co-authored-by: Léopold Jacquot <leopold.jacquot@gmail.com>
Co-authored-by: tbutter <thomas@gmx.net>
Co-authored-by: Thomas Butter <tbutter@gmail.com>
Co-authored-by: Azim Khakulov <azim@khakulov.com>
Co-authored-by: Vertganti <bjoern.meusburger@outlook.at>
Co-authored-by: Matthieu Huguet <matthieu.huguet@fun-mooc.fr>
Co-authored-by: Joy A <54208632+1t5j0y@users.noreply.github.com>
Co-authored-by: Saúl Ibarra Corretgé <saghul@jitsi.org>
Co-authored-by: Kenny <tengfei.lee@gmail.com>
Co-authored-by: Bert Driehuis <driehuis@playbeing.org>
Co-authored-by: Prayag Singh <prayagsingh@users.noreply.github.com>
Co-authored-by: Berbe <4251220+Berbe@users.noreply.github.com>
Co-authored-by: Paul Tiedtke <PaulTiedtke@web.de>
Co-authored-by: CreativeCactus <12624092+CreativeCactus@users.noreply.github.com>
Co-authored-by: Артем <cinquestyle@gmail.com>
Co-authored-by: wfleischer <70745309+wfleischer@users.noreply.github.com>
Co-authored-by: Werner Fleischer <70745309+wernf@users.noreply.github.com>
Co-authored-by: Kevin Conway <kevinjacobconway@gmail.com>
Co-authored-by: waja <waja@users.noreply.github.com>
Co-authored-by: Robert Kaussow <xoxys@rknet.org>
Co-authored-by: Ben Banfield-Zanin <benbz@matrix.org>
Co-authored-by: Daniil Meitis <30820460+dsmeytis@users.noreply.github.com>
Co-authored-by: Daniil Meitis <daniil.meitis@viber.com>
Co-authored-by: Holger Pandel <holger.pandel@googlemail.com>
Co-authored-by: jon r <jon@allmende.io>
Co-authored-by: Boris Grozev <boris@jitsi.org>
Co-authored-by: Robert Kaussow <mail@thegeeklab.de>
Co-authored-by: Markus Münzel <markus.muenzel@mailbox.org>
Co-authored-by: Markus Münzel <markus@muenzel.de>
Co-authored-by: chris-est <c1_github@teamchris.info>
Co-authored-by: JohannesPertl <johannes.pertl@edu.fh-joanneum.at>
Co-authored-by: Yu Changyuan <reivzy@gmail.com>
Co-authored-by: Thorsten B <TheRealBro@users.noreply.github.com>
Co-authored-by: Aaron van Meerten <aaron.van.meerten@gmail.com>
Co-authored-by: Rintan <12230083+Rintan@users.noreply.github.com>
Co-authored-by: Grant Slater <git@firefishy.com>
Co-authored-by: Oana Emilia Ianc <oana.emilia.ianc@gmail.com>
Co-authored-by: Oana Emilia Ianc <oana.ianc@8x8.com>
Co-authored-by: Mahdhi Rezvi <37553533+Mahdhir@users.noreply.github.com>
Co-authored-by: Jean-Vincent kassi <jeanvincent45@gmail.com>
Co-authored-by: Debendra Oli <debendraoli@gmail.com>
Co-authored-by: Daniel McAssey <DanielMcAssey@users.noreply.github.com>
Co-authored-by: Lazaro Herrera <lazherrera@gmail.com>
Co-authored-by: Charlie Calendre <57274151+c-cal@users.noreply.github.com>
Co-authored-by: Michel Pawlak <pawlakm@users.noreply.github.com>
Co-authored-by: BinaryWizard904 <62070150+BinaryWizard904@users.noreply.github.com>
Co-authored-by: Debendra Oli <debendraoli@pm.me>
Co-authored-by: Timo Schwarzer <timo@schwarzer.dev>
Co-authored-by: Timo Schwarzer <me@timoschwarzer.com>
Co-authored-by: David Négrier <d.negrier@thecodingmachine.com>
Co-authored-by: Rhys <66695742+RhysRdm@users.noreply.github.com>
Co-authored-by: Ubuntu <ubuntu@ip-172-31-28-166.ec2.internal>
Bishwarupjee added a commit to Bishwarupjee/docker-jitsi-meet that referenced this issue Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants