-
Notifications
You must be signed in to change notification settings - Fork 6.7k
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disableDeepLinking : true has stopped working #12724
Comments
Is this the same as my case with the latest release? I'm trying to allow mobile browsers without Mobile app promo (previously it worked). If I use After clicking "Use desktop version" user can use mobile browser. |
We are not using MOBILE_APP_PROMO, but disableDeepLinking : true was working perfectly before as it was skipping the selection "where to launch jitsi video". But recently it has stopped working and now the selection page has started to appear. User are unable to connect directly on video but has to choose the launch in web option first. |
Thanks, anyway, in our case the main problem is the same By the way, if I use this setting in URL, it works. i.e. Another refs. with recently updates: |
@saghul do we want the deprecated config (if set) to take precedence over the new one for disabling deeplinking? Thank you. |
If the new one is not set, then the old one should work. |
The new one is set on the deploy - so currently the old one is completely ignored |
There is definitely still a bug here, possibly because in react/features/deep-linking/functions.ts the getDeepLinkingPage() function does a "return Promise.resolve()", and then back in react/features/app/getRouteToRender.web.ts function _getWebConferenceRoute() cannot convert void to boolean in the "if (deepLinkComponent)". |
@DamjanJovanovic the given Line 1214 in f847a3e
|
On my self-hosted Debian box, with clients using the IFrame API, in /usr/share/jitsi-meet-web-config/config.js I had both:
and it still wasn't working. The only way I got it to work is by hacking the deep linking code to completely disable it with my patch below, then building the patched jitsi-meet project ( While developing this patch, I got some compile-time error about conversion of void to boolean during "make", which is why I
Debian packages installed are: |
Download Jitsi App or Launch in Web option is still appearing on mobile browsers. It was working few days back.
The text was updated successfully, but these errors were encountered: