-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(breakout-rooms): moderation of visibility #10696
Conversation
Hi, thanks for your contribution! |
What is the intent of this? To hide the room to non-moderators for a bit? Shouldn't LJM filter the rooms when emitting the events in case you have a new front end talking to an older backend? I worry about backwards compatibility on this one, specially on mobile, where the front end is not updated at the same time as the backend. |
a66286f
to
9a470c2
Compare
9a470c2
to
c7a70ad
Compare
Thank you, @saghul for your valuable feedback.
Yes. This is to allow moderators to prepare the breakout rooms and control when they can be used.
This is a valid concern. I have updated this and the related lib-jitsi-meet PR to hide the moderation option if the feature is not supported on the backend. Please have a look. |
Marked this as WIP for now. This PR is pending on some UI redesign. No ETA. Sorry. |
@saghul, @hristoterezov: Please take a look at this feature request, similar to the breakout rooms renaming PR. Let me know if you want me to rebase. |
I think it would make sense to have it, but I defer to @hristoterezov since I won't have the cycles to review it in the short term. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sigh. @wfleischer if you are still interested in this please rebase it and I will review it. |
Sorry for the late reply, @saghul! I was a bit busy with other stuff. I will be happy to provide a rebase. Thank you for considering! |
Closing as superseded by #14676 |
Allowing moderators to control the visibility of breakout rooms to the participants. See the related PR jitsi/lib-jitsi-meet#1833.