Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breakout-rooms): moderation of visibility #10696

Closed
wants to merge 1 commit into from

Conversation

wfleischer
Copy link
Contributor

Allowing moderators to control the visibility of breakout rooms to the participants. See the related PR jitsi/lib-jitsi-meet#1833.

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@saghul
Copy link
Member

saghul commented Dec 24, 2021

What is the intent of this? To hide the room to non-moderators for a bit?

Shouldn't LJM filter the rooms when emitting the events in case you have a new front end talking to an older backend?

I worry about backwards compatibility on this one, specially on mobile, where the front end is not updated at the same time as the backend.

@wfleischer
Copy link
Contributor Author

Thank you, @saghul for your valuable feedback.

What is the intent of this? To hide the room to non-moderators for a bit?

Yes. This is to allow moderators to prepare the breakout rooms and control when they can be used.

Shouldn't LJM filter the rooms when emitting the events in case you have a new front end talking to an older backend?

I worry about backwards compatibility on this one, specially on mobile, where the front end is not updated at the same time as the backend.

This is a valid concern. I have updated this and the related lib-jitsi-meet PR to hide the moderation option if the feature is not supported on the backend. Please have a look.

@wfleischer wfleischer changed the title feat(breakout-rooms): moderation of visibility WIP: feat(breakout-rooms): moderation of visibility Mar 17, 2022
@wfleischer
Copy link
Contributor Author

Marked this as WIP for now. This PR is pending on some UI redesign. No ETA. Sorry.

@wfleischer wfleischer changed the title WIP: feat(breakout-rooms): moderation of visibility feat(breakout-rooms): moderation of visibility Jul 19, 2023
@wfleischer
Copy link
Contributor Author

@saghul, @hristoterezov: Please take a look at this feature request, similar to the breakout rooms renaming PR. Let me know if you want me to rebase.

@saghul
Copy link
Member

saghul commented Jul 31, 2023

I think it would make sense to have it, but I defer to @hristoterezov since I won't have the cycles to review it in the short term.

Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 20, 2024
@saghul
Copy link
Member

saghul commented Jan 22, 2024

Sigh. @wfleischer if you are still interested in this please rebase it and I will review it.

@github-actions github-actions bot removed the stale label Jan 23, 2024
@wfleischer
Copy link
Contributor Author

Sigh. @wfleischer if you are still interested in this please rebase it and I will review it.

Sorry for the late reply, @saghul! I was a bit busy with other stuff. I will be happy to provide a rebase. Thank you for considering!

@wfleischer
Copy link
Contributor Author

wfleischer commented Apr 25, 2024

Closing as superseded by #14676

@wfleischer wfleischer closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants