feat(ios/android/sdk): delegate transcription chunk received event #14516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinteodor
commented
Mar 21, 2024
saghul
requested changes
Mar 21, 2024
Calinteodor
force-pushed
the
transcription-chunk-recieved-sdk
branch
3 times, most recently
from
7f2b755
to
655e643
Compare
saghul
requested changes
Mar 28, 2024
| @@ -255,6 +255,10 @@ protected void onReadyToClose() { | |||
| finish(); | |||
| } | |||
|
|
|||
| protected void onTranscriptionChunkReceived(HashMap<String, Object> extraData) { | |||
| JitsiMeetLogger.i("Transcription chunk received: " + extraData); | |||
There was a problem hiding this comment.
Don't put this here. Put it in the main activity, and commented out.
There was a problem hiding this comment.
I see that all the other events like CONFERENCE_TERMINATED or READY_TO_CLOSE are here and MainActivity extends JitsiMeetActivity.
There was a problem hiding this comment.
READY_TO_CLOSE is special because it terminates the activity. The rest shouldn't really be there...
There was a problem hiding this comment.
Can we leave it as it is right now and do a separate PR where we tackle all the events after this?
Co-authored-by: Saúl Ibarra Corretgé <s@saghul.net>
Calinteodor
force-pushed
the
transcription-chunk-recieved-sdk
branch
from
b6d9f8e
to
e4824b0
Compare
saghul
reviewed
Mar 28, 2024
saghul
reviewed
Mar 28, 2024
Calinteodor
force-pushed
the
transcription-chunk-recieved-sdk
branch
from
4c71b93
to
4587d93
Compare
saghul
previously approved these changes
Mar 28, 2024
saghul
approved these changes
Mar 28, 2024
liumengyuan1997
pushed a commit
to liumengyuan1997/jitsi-meet
that referenced
this pull request
Jun 19, 2024
…itsi#14516) * feat(subtitles): created separate helpers for delegating transcription chunks events on web and mobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.