Displays the region participants are connected to #3451
Conversation
|
|
| @@ -430,6 +433,7 @@ class ConnectionIndicator extends Component { | |||
| packetLoss = { packetLoss } | |||
| region = { region } | |||
| resolution = { resolution } | |||
| serverRegion = { serverRegion } | |||
| shouldShowMore = { this.state.showMoreStats } | |||
There was a problem hiding this comment.
Dang, maybe at this point, not saying for this PR, ConnectionStatsTable should just take in the stats object itself or we use a spread operator to pass in all stat values ({ ...this.state.stats })or have ConnectionStatsTable listen instead of just ConnectionIndicator.
| * The number of bridges (aka media servers) currently used in the | ||
| * conference. | ||
| */ | ||
| bridgeCount: PropTypes.string, |
There was a problem hiding this comment.
The count is really a string and not a number?
There was a problem hiding this comment.
Haha, nice attention to detail. I had it as a number, but there was an error at some point and I took the lazy way out :)
I'll make it a number and make sure that that's what the lib emits.
| let str = serverRegion; | ||
|
|
||
| if (!serverRegion) { | ||
| return; |
There was a problem hiding this comment.
Would you prefer showing N/A over not showing the row?
There was a problem hiding this comment.
I decided to hide it because of deployments where regions are not configured. There it would show 'N/A' permanently (while for the rest of the stats it is reasonable to expect that they will appear once we get the data).
| @@ -86,6 +92,11 @@ class ConnectionStatsTable extends Component { | |||
| */ | |||
| resolution: PropTypes.object, | |||
|
|
|||
| /** | |||
| * The region of the media server. | |||
There was a problem hiding this comment.
Maybe there needs to be a distinction made between region and serverRegion, at least in the docs.
lang/main.json
Outdated
| "bitrate": "Bitrate:", | ||
| "bridge_count": "Server count: ", |
There was a problem hiding this comment.
So I think maybe not using snake_case is okay. At some point the other snake_case strings should probably be changed to camelCase.
There was a problem hiding this comment.
oh, ok, I didn't know that.
| @@ -373,8 +435,10 @@ class ConnectionStatsTable extends Component { | |||
| { this._renderBitrate() } | |||
| { this._renderPacketLoss() } | |||
| { isRemoteVideo ? this._renderE2eRtt() : null } | |||
| { isRemoteVideo ? this._renderRegion() : null } | |||
There was a problem hiding this comment.
I recall you asking me about this. I think you can also do isRemoteVideo && this._renderRegion() and get the same result, but either words for me.
and the number of (media) servers in the stats panels.