Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a message handler. #98

Merged
merged 1 commit into from Sep 16, 2014
Merged

Conversation

fouksf
Copy link
Contributor

@fouksf fouksf commented Aug 18, 2014

No description provided.

@fouksf fouksf force-pushed the message-handler branch 11 times, most recently from 5a48f01 to 55cf630 Compare August 29, 2014 08:49
@fouksf fouksf force-pushed the message-handler branch 5 times, most recently from c0be022 to fbe8bcd Compare September 11, 2014 14:07
@bgrozev
Copy link
Member

bgrozev commented Sep 11, 2014

I'm not sure I'm looking at a finished version of this (the current commit id is fbe8bcd). It looks ok to me, except for the 'bridgeIsDown' signalling. Maybe this is due to the change from one format to another, but currently: the code reading the presence looks for 'available' and it shouldn't, the addVideoBridgeStatus function should probably be renamed since (now) it accepts a boolean, the "bridgeIsDown" variable seems unused.

There seem to be quite a few error messages which are the same, or nearly the same, and don't provide any details about the error to the user. Emil wrote elsewhere that we should show them nevertheless, because they show to the user the fact that something went wrong. I suggest a generic 'oops' function in MessageHandler to be used for all these. This way we can more easily control if a dialog is shown, or if another form of notification is used.

@fouksf fouksf force-pushed the message-handler branch 4 times, most recently from 3b45486 to a027f00 Compare September 16, 2014 14:15
hristoterezov added a commit that referenced this pull request Sep 16, 2014
@hristoterezov hristoterezov merged commit aaf444b into jitsi:master Sep 16, 2014
@fouksf fouksf deleted the message-handler branch September 23, 2014 13:30
ghost pushed a commit to saal-core/blync-meet-mediator that referenced this pull request Nov 21, 2020
VMEET-160 disable shortcut keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants