-
Notifications
You must be signed in to change notification settings - Fork 962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XMPP contact in multiple groups #88
Comments
We have just started using jitsi and this is a big nuisance for us, as it makes groups essentially useless! |
I see that a new version came out today, but in the changelog there is still no fix for this issue :-( |
This would be a big help... |
Still happening |
@mpicher Will you help with testing if I provide build for you? |
@djadk84 the same question. |
@ibauersachs does it make a sence to add something like version to contact list cache? I mean contactlist.xml. Currently when there is no any option for checking cache version Jitsi doesn't show contact in multiple groups untill I don't remove contactlist.xml or remove/add account. |
I'm unsure why this is needed, but I don't care much about a version attribute if it's necessary. |
@GNUDimarik - yes! |
@mpicher here is the build: https://www.dropbox.com/s/yc8f2v0n92wv25d/jitsi-2.11.0-x86.exe?dl=0 |
@mpicher pls ignore that build. I was very wrong. I understood right way for implementation. Commints above are wrong. |
Ok, just let me know when you're ready.
On Sat, Sep 15, 2018, 5:16 PM Dmitry A ***@***.***> wrote:
@mpicher <https://github.com/mpicher> pls ignore that build. I was very
wrong. I understood right way for implementation. Commints above are wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACdMIm9z4AbSRo8fg7mu3O-sRp-CG6qBks5ubW4fgaJpZM4D67Qb>
.
--
Thanks,
Mike
…-----------------------------------------------------------------------------------------
I'll do today what others don't so that I can do tomorrow what others
can't. - Mat Fraser
|
@mpicher thanks!!! |
I noticed when I adding user to second or third groups server not always send me update info about all members .... But may be it's my network. |
Thx, is there a Mac build?
…On Thu, Sep 20, 2018, 9:02 AM Dmitry A ***@***.***> wrote:
I noticed when I adding user to second or third groups server not always
send me update info about all members .... But may be it's my network.
@mpicher <https://github.com/mpicher> please share the logs if you have
some issues.
Thanks for your help!!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACdMIv_BO-6-CJMHHukjmMSRzVVK5r84ks5uc5HAgaJpZM4D67Qb>
.
|
There is windows build. Will ask friend to make Mac one. |
@AlexKuznetsoff pls make mac build |
Hey Dmitry,
What's the status of this?
Thanks,
Mike
There are 10 kinds of people in this world, those who understand binary and
those who don't.
mpicher@gmail.com
blog: http://www.sipxecs.info
call: sip:mpicher@sipxecs.info
…On Mon, Oct 8, 2018 at 11:46 AM Dmitry A ***@***.***> wrote:
Coming soon ...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#88 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ACdMItM2muOeTBvJATrs0mRx2z7ik7spks5ui3NngaJpZM4D67Qb>
.
|
@mpicher I think it's 70% complete just last two weeks I had no chance to work on this. Will continue soon. |
@ibauersachs I have a lot of changes ... is this good for review to make multiple commits? |
It's good to have multiple commits so you can track your changes. It doesn't really matter for reviewing though as I'm only looking at the complete diff, not individual commits. |
FInally I have time to back to this. Last time I fixed all issues except presence handling. |
Damencho might give some advice there in the community forum. |
No. I used master. But it's no problem I can switch to new smak. Here is my old question about that: |
@damencho shall we merge smack4-2 back to master? I don't think anybody cares about a 2.12 release anymore anyway. |
We can. And this will update to java8 and currently builds are disabled cause we don't have windows certs. |
Wdyt? |
Yeah, just merge. Ubuntu 18.04 LTS has Java 11 and Debian Buster with Java 11 is in freeze. Can you get a Windows Cert via 8x8? |
Will give you an answer today. |
It would be great to merge new smack to master since it automatically should fix some opened issues. Afair somewhere I saw some requests for stream control or something similar. Also it opens door to easy implementation of OMEMO etc |
@ibauersachs I understand it's unrelated topic but I working on porting directshow wrapper for gstreamer now: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/merge_requests/12#note_151674 |
libjitsi is already flexible enough to add another audio/video backend. If you want to go for that, feel free. But I'd rather concentrate on stabilizing or updating the existing backends, e.g. updating PortAudio, or creating a build pipeline (e.g. on Azure) that builds the entire libjitsi + libjitsi-(l)gpl from source for all platforms. Regarding OMEMO, this would need to be a standalone plugin, not affiliated with the Jitsi project itself, because of the licensing issues. But AFAIK even Smack 4.2 is now rather outdated. An update to 4.3.x shouldn't be as painful anymore as it was for 4.2 though. @damencho if someone (i.e. currently not me) would do that, any objections for Videobridge&Friends? |
I have experience with porting Jitsi fork to smack 4.4.1-alpha (at that moment). Previously I ported it to 4.3 and switching from 4.3 to 4.4.1 required updating jxmpp and something else. |
We do not mind, except for some time(for 3 more months), we may continue using 4.2 branch to no add some unknown risks and if we want some fixes we will need to push them on both places. We had extracted the custom smack extensions in a separate project, I hope those do not need update moving to 4.3, as we will need to also branch those. |
@ibauersachs after your suggestion about stabilization of current stuff instead of implementation new one I checked one thing in current directshow code. It seems there are some memory leaks ... |
@damencho when do you think smack-4 should be merged to current master? |
@ibauersachs @damencho once I have time on this issue again I'll switch development to branch smack 4-2 then and after changes will be able to merged to master with that branch. |
No, it doesn't. Take smack4-2 as the base branch for all improvements. |
@ibauersachs |
Master, but all builds are currently disabled. |
@ibauersachs |
We will merge it next week. |
@damencho |
@GNUDimarik: You can look my tickets about XMPP ;)
|
Not really. I working on Jitsi for free (in general) and only when I have time.
|
I have a XMPP contact that is in 2 groups. However Jitsi only shows contact in one of these.To reproduce and expected output:
Expected:
Show contact in both groups
Current:
Contact is only shown in 1 group
(Issue migrated from https://trac.jitsi.org/ticket/1113)
The text was updated successfully, but these errors were encountered: