Oops. I was just trying to open a pull for one particular commit. Not all of them. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipe does not work for whatever reason so a more standard working solution is used.
|
This is just our first try. If anyone has a better way to do this we we are open to suggestions. |
| @@ -27,5 +27,5 @@ | |||
| /** | |||
| * The build ID. | |||
| */ | |||
| public static final String BUILD_ID="0.build.by.SVN"; | |||
| public static final String BUILD_ID="1"; | |||
| } | |||
There was a problem hiding this comment.
When invoking ant you just need to pass -Dlabel="1" and this is going to be set as build version.
powerpbx
changed the title
|
You should work on a branch, not on master. And for a pull request you need to do that. |
| @@ -573,7 +573,7 @@ | |||
| todir="${light.dir}" | |||
| overwrite="true" /> | |||
|
|
|||
| <property name="wix.home" value="C:\Program Files\WiX" /> | |||
| <property name="wix.home" value="C:\wix310" /> | |||
There was a problem hiding this comment.
This also can be controlled with passing parameters to ant as -Dwix.home="C:\wix310".
|
Thanks for the info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.