Skip to content

Commit

Permalink
feat: Enable TCC support on Firefox.
Browse files Browse the repository at this point in the history
TCC was disabled on older versions because of a known issue where BWE is halved on every renegotiation. The regular libwebrtc updates in Firefox seems to have fixed it. This hopefully fixes the BWE issues seen on Firefox 117.
  • Loading branch information
jallamsetty1 committed Sep 19, 2023
1 parent 75d2a9d commit eab806a
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions modules/xmpp/xmpp.js
Expand Up @@ -231,8 +231,10 @@ export default class XMPP extends Listenable {
this.caps.addFeature('http://jitsi.org/remb');
}

// Disable TCC on Firefox because of a known issue where BWE is halved on every renegotiation.
if (!browser.isFirefox() && (typeof this.options.enableTcc === 'undefined' || this.options.enableTcc)) {
// Disable TCC on Firefox 116 and older versions because of a known issue where BWE is halved on every
// renegotiation.
if (!(browser.isFirefox() && browser.isVersionLessThan(117))
&& (typeof this.options.enableTcc === 'undefined' || this.options.enableTcc)) {
this.caps.addFeature('http://jitsi.org/tcc');
}

Expand Down

1 comment on commit eab806a

@JOpsDev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still seeing the "Sources suspended due to
insufficient bandwidth (bwe=-1 bps)" problem with latest unstable of yesterday and Firefox 118.0.2.

Please sign in to comment.