e2ee: also enable on p2p connections #1107
Conversation
|
@saghul I don't think that is quite enough and needs additional handling in _setupSenderE2EEForTrack (and the receiver), right? |
|
(also is this more complicated? what about transitions...) |
fippo
changed the title
also enables e2ee on peer-to-peer connections. While a bit unnecessary it avoids the confusing UX of things working until a third person joins
|
I'll check, I think some more stuff is needed. |
|
I think I found them all. API change: _setupSenderE2EEForTrack gets the jvb/p2p session as first argument |
| return; | ||
| } | ||
| const session = track.isP2P ? this.p2pJingleSession : this.jvbJingleSession; | ||
| const pc = session && session.peerconnection; |
| if (!this._e2eeCtx) { | ||
| return; | ||
| } | ||
| const pc = session.peerconnection; |
There was a problem hiding this comment.
We ccould use geetActiveTPC` here as well instead of passsing the session around.
There was a problem hiding this comment.
but I want the peerconnection the track is received on, no matter what the current establishment status of the p2p ice connection is?
There was a problem hiding this comment.
That is taken care of by caller function already, isn't it?
There was a problem hiding this comment.
no, this is called from JitsiConference.prototype.onCallAccepted (line 1701) for p2p and JitsiConference.prototype._acceptJvbIncomingCall for the sfu call. In both cases we know exactly where this is originating
also enables e2ee on peer-to-peer connections. While a bit unnecessary
it avoids the confusing UX of things working until a third person joins