Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TPC): make screen share bitrate configurable #2215

Merged
merged 4 commits into from
Feb 14, 2023
Merged

fix(TPC): make screen share bitrate configurable #2215

merged 4 commits into from
Feb 14, 2023

Conversation

DanielMcAssey
Copy link
Contributor

@DanielMcAssey DanielMcAssey commented Feb 9, 2023 •
edited
Loading

This makes the screenshare bitrate configurable if using VP9. Happy to make changes.

Not sure if localStreamEncodingsConfig needs to change as well

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@DanielMcAssey
Copy link
Contributor Author

I have updated it to also update the localStreamEncodings for desktop sharing. After looking at the code I believe its required.

jallamsetty1
jallamsetty1 reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@jallamsetty1 jallamsetty1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielMcAssey Thanks for the PR, this LGTM, left 2 minor comments.

modules/RTC/TPCUtils.js Show resolved Hide resolved
modules/RTC/TPCUtils.js Show resolved Hide resolved
@jallamsetty1
Copy link
Member

Jenkins test this please.

@jallamsetty1
Copy link
Member

Jenkins test this please.

@DanielMcAssey
Copy link
Contributor Author

@jallamsetty1 thank you, sorted those 2 comments 👍🏻

@jallamsetty1 jallamsetty1 merged commit 829f5ac into jitsi:master Feb 14, 2023
@DanielMcAssey DanielMcAssey deleted the dev/make-desktop-bitrate-configurable branch February 14, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jallamsetty1 jallamsetty1 jallamsetty1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielMcAssey @jitsi-jenkins @jallamsetty1