Fix screenshare issues #2304
Merged
Fix screenshare issues #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itch. Fixes blurry screenshare in some cases. There is a higher probability of the higher layers getting suspended when all the stream encodings are enabled for low fps SS. Make sure only the highest spatial layer is sent for low fps SS after p2p->jvb switch. Make sure all the stream encodings are enabled for high fps SS after p2p->jvb switch.
…ectly. contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes jitsi#2298.
saghul
approved these changes
Jun 28, 2023
| * @param {MediaStreamTrack} track - the track that is transmitted | ||
| * @param {String} hint - contentHint value that needs to be set on the track | ||
| */ | ||
| setVideoTrackContentHints(track, hint) { |
There was a problem hiding this comment.
Doesn't this break the public API?
There was a problem hiding this comment.
Actually this is not documented as a public API, this should have been a private function when it was added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes blurry screenshare in some cases. There is a higher probability of the higher layers getting suspended when all the stream encodings are enabled for low fps SS. Make sure only the highest spatial layer is sent for low fps SS after p2p->jvb switch. Make sure all the stream encodings are enabled for high fps SS after p2p->jvb switch.
contentHint needs to be set to 'motion' for high fps SS and 'detail' otherwise. Fixes #2298.