Fixes instanceof JitsiTrackError #309
Conversation
| @@ -29,109 +29,111 @@ TRACK_ERROR_TO_MESSAGE_MAP[JitsiTrackErrors.TRACK_MUTE_UNMUTE_IN_PROGRESS] | |||
| TRACK_ERROR_TO_MESSAGE_MAP[JitsiTrackErrors.NO_DATA_FROM_SOURCE] | |||
| = "The track has stopped receiving data from it's source"; | |||
|
|
|||
|
|
|||
| // FIXME: Using prototype inheritance because otherwise instanceof is not | |||
There was a problem hiding this comment.
The comment is a bit misleading about the bug. From the issues description one can figure out that it's not recommended to extend a built-in type (and so does the PR description), but the comment looks like we're waiting for the bug to be fixed.
There was a problem hiding this comment.
If the bug got fixed I think it's gonna be better to return back to the ES6 syntax. Do you want me to include this information in the comment?
There was a problem hiding this comment.
No, I got the code wrong and thought that we will not longer extend Error - it's ok as it is.
| /** | ||
| * | ||
| * Represents an error that occurred to a JitsiTrack. Can represent various | ||
| * types of errors. For error descriptions (@see JitsiTrackErrors). | ||
| * | ||
| * @extends Error |
There was a problem hiding this comment.
It does not extend the Error anymore, does it ?
Do we have any usages of JitsiTrackError that rely on that fact ?
There was a problem hiding this comment.
It still extends Error. See the lines after the constructor:
JitsiTrackError.prototype = Object.create(Error.prototype);
JitsiTrackError.prototype.constructor = JitsiTrackError;
I'm not sure where and why we are using this but even if we are not using it I think it's good to extend Error since we are reporting error.
There was a problem hiding this comment.
ok, makes sense, thanks for the explanation !
JitsiTrackError extends Error. Due to an issue with babel, extending built-in classes seems not very good idea(babel/babel#3083).
This PR fixes
instanceof JitsiTrackErrorcalls.